Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DIGRAPHS_OmitFromTests dynamic? #536

Open
wilfwilson opened this issue Mar 30, 2022 · 2 comments
Open

Make DIGRAPHS_OmitFromTests dynamic? #536

wilfwilson opened this issue Mar 30, 2022 · 2 comments
Labels
minor A label for PRs or issues that are minor in some sense. technical A necessary technical change, not interesting mathematically/feature-wise

Comments

@wilfwilson
Copy link
Collaborator

Just a minor note.

@fingolfin noticed in #535 (comment):

DIGRAPHS_OmitFromTests is initialized once and then not updated. This could be fixed, e.g. by removing DIGRAPHS_OmitFromTests and modifying the code which currently uses it to directly use DIGRAPHS_IsGrapeLoaded() -- the code would arguably be simpler, too. But I don't know if you have plans to use DIGRAPHS_OmitFromTests more or have other needs for it, so I didn't do that in this PR.

In essence, Grape might be loaded sometime after Digraphs is loaded (if Digraphs is loaded with the OnlyNeeded option), so it maybe makes sense to check whether Grape is loaded each time DIGRAPHS_OmitFromTests is needed.

This won't affect our testing setup, since we don't test with the OnlyNeeded option (and even if we didn't, we don't later load Grape).

@wilfwilson wilfwilson added minor A label for PRs or issues that are minor in some sense. technical A necessary technical change, not interesting mathematically/feature-wise labels Mar 30, 2022
@james-d-mitchell
Copy link
Member

I'm happy to go for this, sounds very sensible!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor A label for PRs or issues that are minor in some sense. technical A necessary technical change, not interesting mathematically/feature-wise
Projects
None yet
Development

No branches or pull requests

2 participants