You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DIGRAPHS_OmitFromTests is initialized once and then not updated. This could be fixed, e.g. by removing DIGRAPHS_OmitFromTests and modifying the code which currently uses it to directly use DIGRAPHS_IsGrapeLoaded() -- the code would arguably be simpler, too. But I don't know if you have plans to use DIGRAPHS_OmitFromTests more or have other needs for it, so I didn't do that in this PR.
In essence, Grape might be loaded sometime after Digraphs is loaded (if Digraphs is loaded with the OnlyNeeded option), so it maybe makes sense to check whether Grape is loaded each time DIGRAPHS_OmitFromTests is needed.
This won't affect our testing setup, since we don't test with the OnlyNeeded option (and even if we didn't, we don't later load Grape).
The text was updated successfully, but these errors were encountered:
wilfwilson
added
minor
A label for PRs or issues that are minor in some sense.
technical
A necessary technical change, not interesting mathematically/feature-wise
labels
Mar 30, 2022
Just a minor note.
@fingolfin noticed in #535 (comment):
In essence, Grape might be loaded sometime after Digraphs is loaded (if Digraphs is loaded with the
OnlyNeeded
option), so it maybe makes sense to check whether Grape is loaded each timeDIGRAPHS_OmitFromTests
is needed.This won't affect our testing setup, since we don't test with the
OnlyNeeded
option (and even if we didn't, we don't later load Grape).The text was updated successfully, but these errors were encountered: