Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces: Add CORS Configuration Support #1021

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Spaces: Add CORS Configuration Support #1021

merged 8 commits into from
Aug 29, 2023

Conversation

danaelhe
Copy link
Member

Address #1015

Users can configure advance settings for CORS via the digitalocean_spaces_bucket_cors_configuration resource.

@danaelhe danaelhe requested a review from a team August 21, 2023 19:38
@danaelhe danaelhe changed the title Spaces: Add CORS Coniguration Support Spaces: Add CORS Configuration Support Aug 21, 2023
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running into some issues trying to run the tests.

@@ -62,6 +62,7 @@ func ResourceDigitalOceanBucket() *schema.Resource {
Type: schema.TypeList,
Optional: true,
Description: "A container holding a list of elements describing allowed methods for a specific origin.",
Deprecated: "Terraform will only perform drift detection if a configuration value is provided. Use the resource `digitalocean_spaces_bucket_cors_configuration` instead.",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding deprecation flag to encourage users to use digitalocean_spaces_bucket_cors_configuration. AWS deprecated this to add more flexibility with bucket creations:
hashicorp/terraform-provider-aws#4418

@danaelhe
Copy link
Member Author

Running into some issues trying to run the tests.

ooof, at first I was running the test in a way that gave me false positives. Thanks for double checking.

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed a couple more small changes to the tests to get them passing.

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Let's go!

@danaelhe danaelhe merged commit f5bd1a1 into main Aug 29, 2023
2 checks passed
@danaelhe danaelhe deleted the spaces_cors branch August 29, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants