Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save only the relative path of the filename for StaticDirStorage #1990

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Save only the relative path of the filename for StaticDirStorage #1990

wants to merge 1 commit into from

Conversation

amitaibu
Copy link
Collaborator

fixes #1989

@amitaibu
Copy link
Collaborator Author

I still need to verify it locally, but looking here:

ihp/IHP/FileStorage/ControllerFunctions.hs

Lines 223 to 229 in a58f7a0

createTemporaryDownloadUrlFromPathWithExpiredAt :: (?context :: context, ConfigProvider context) => Int -> Text -> IO TemporaryDownloadUrl
createTemporaryDownloadUrlFromPathWithExpiredAt validInSeconds objectPath = do
publicUrlExpiredAt <- addUTCTime (fromIntegral validInSeconds) <$> getCurrentTime
case storage of
StaticDirStorage -> do
let frameworkConfig = ?context.frameworkConfig
let url = frameworkConfig.baseUrl <> "/" <> objectPath

It looks like it's expecting objectPath to be relative. So Likely this is also a bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save only the relative path of the filename in storeFileWithOptions
1 participant
@amitaibu