Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav bar and coaching marks.. #1

Open
wdcurry opened this issue May 21, 2018 · 4 comments
Open

nav bar and coaching marks.. #1

wdcurry opened this issue May 21, 2018 · 4 comments

Comments

@wdcurry
Copy link

wdcurry commented May 21, 2018

hey, awesome effort! Testing it out, and my main need for coaching lives up in the nav bar, and the graphics are rendering under the bar, which makes it very confusing to use. For now I will create a fake screen with controls to be accessible, but thought to let you know. Looks like a little z-order tweak is in order? Cheers!

@Choock
Copy link
Contributor

Choock commented May 22, 2018

Hey! You are our first external user :) Thank you!
To show the marks above other content you can use app main window as a container. I think it's a good idea to add a method creating the marks in the window by default to cover most of the usual use cases like yours. Would you check this and let me know? :)

@Choock Choock self-assigned this May 22, 2018
@wdcurry
Copy link
Author

wdcurry commented May 22, 2018

I will.. nice repo btw.. I am struggling a bit to get the git rolling. Redirecting it to use the dev branch to test. One huge bit of cool to help us external folks: having to walk and extract code from the demo is painful for many ;) BUT.. this coupled with a regular on boarding set of pages is the best way to intro users to a new app.

@wdcurry
Copy link
Author

wdcurry commented Jun 1, 2018

i got sidetracked with a test app for a potential gig, and will return to this shortly. Just in case you are testing a mark on the navbar, feel free to let me know, as i can test. I am likely going to replicate the mark in question to a space just below the bar and use that, and try just pushing the coordinates up and over the navbar to see if i can make it "just work" ..

@wdcurry
Copy link
Author

wdcurry commented Jun 2, 2018

Interestingly, at least to me ;), this issue with the navbar led me to a better solution for an fuller intro. I couldn't get the marks to display over the navbar, and thus decided to create screenshots, create new control views over the area of the buttons to mark. Seemed like more work until i realized the structure to encapsulate calls and images in sequence that allows me to show all screens options properly, in one new viewcontroller rather than marking up each view involved.

I may not have thought of it if i was able to access the controls directly. This not entirely ideal, i do like dropping all this into one VC. The other way would involve firing up each involved view in sequence.

It's all good. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants