Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qa updates #374

Open
wants to merge 2 commits into
base: QuestionAnswering
Choose a base branch
from
Open

Qa updates #374

wants to merge 2 commits into from

Conversation

LukasBluebaum
Copy link
Contributor

Copy link
Member

@MichaelRoeder MichaelRoeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the necessity of the reflections dependency.

<groupId>org.reflections</groupId>
<artifactId>reflections</artifactId>
<version>0.9.12</version>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this dependency needed? The project is built for me without issues when I comment out the dependency 🤔

Copy link
Contributor Author

@LukasBluebaum LukasBluebaum Dec 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late answer.
The thing is when I don't set the version to 0.9.12, then version 0.9.11 will be used. And that version seems to have a multithreading issue.

So in the default case in NLIWODBasedSystem the reflections dependency is used to retrieve names of systems in qa.systems. Now, when an experiment is started with multiple systems that execute the default case (e.g. TeBaQA, QAmp, Platypus), then two of the threads will throw a java.lang.IllegalStateException: zip file closed exception. Version 0.9.12 doesn't seem to have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants