Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to list remote available extensions #3896

Merged
merged 11 commits into from
Sep 4, 2024

Conversation

vincent-dfinity
Copy link
Contributor

@vincent-dfinity vincent-dfinity commented Aug 29, 2024

Description

  • Add a separate src/dfx-core/src/extension/manager/list.rs file for listing related functions.
  • Add support to list remote extensions. The usage is described as below:
    1. dfx extensions list
      This will list the installed extensions
    2. dfx extensions list --catalog-url=<...>
      This will list the available extensions with the given catalog URL.
    3. dfx extensions list --available
      This will list the available extensions with the default catalog URL.

Below is an example of the output of the command:

$ dfx extension list --catalog-url=https://raw.githubusercontent.com/vincent-dfinity/dfx-extensions/main/catalog.json
Remote extensions:
  sns
  test
  nns

Fixes # (issue)

SDK-1636

How Has This Been Tested?

  • Manually tested.
  • New e2e tests added.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

src/dfx/src/commands/extension/list.rs Outdated Show resolved Hide resolved
src/dfx/src/commands/extension/list.rs Outdated Show resolved Hide resolved
src/dfx/src/commands/extension/list.rs Outdated Show resolved Hide resolved
src/dfx/src/commands/extension/list.rs Outdated Show resolved Hide resolved
src/dfx-core/src/extension/manager/list.rs Outdated Show resolved Hide resolved
src/dfx-core/src/extension/manager/list.rs Outdated Show resolved Hide resolved
@vincent-dfinity vincent-dfinity marked this pull request as ready for review August 30, 2024 12:54
@vincent-dfinity vincent-dfinity requested a review from a team as a code owner August 30, 2024 12:54
@vincent-dfinity vincent-dfinity merged commit 8072c82 into master Sep 4, 2024
297 checks passed
@vincent-dfinity vincent-dfinity deleted the vincent/SDK-1636 branch September 4, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants