From 7ca709b524b59f66c715ed943dae5ad750befa6a Mon Sep 17 00:00:00 2001
From: David Dal Busco <david.dalbusco@dfinity.org>
Date: Tue, 4 Jun 2024 12:31:01 +0200
Subject: [PATCH] test: more test data for ckETH encodePrincipalToEthAddress
 (#649)

# Motivation

I found more test sample data in the IC repo
([here](https://github.com/dfinity/ic/blob/57414764febc827070ccaf9584f2a59c19c52f45/rs/ethereum/cketh/minter/tests/principal_to_bytes_test.js#L5))
to test the `encodePrincipalToEthAddress` utility of ckETH. So, I
thought it would be cool to replicate those in ic-js as well.

# Changes

- Add more test data and expected results in `@dfinity/cketh`.

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
---
 packages/cketh/src/utils/minter.utils.spec.ts | 48 +++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/packages/cketh/src/utils/minter.utils.spec.ts b/packages/cketh/src/utils/minter.utils.spec.ts
index 98d60c41b..8b37d0be0 100644
--- a/packages/cketh/src/utils/minter.utils.spec.ts
+++ b/packages/cketh/src/utils/minter.utils.spec.ts
@@ -20,6 +20,34 @@ describe("minter-utils", () => {
   const ethExample3 =
     "0x1dc44cf92929cd2f274b6ec1a5f4bcfe0542d1efbb155678a2b58efc31020000";
 
+  const mockPrincipalExample4 = Principal.from(
+    "k2t6j-2nvnp-4zjm3-25dtz-6xhaa-c7boj-5gayf-oj3xs-i43lp-teztq-6ae",
+  );
+  const ethExample4 =
+    "0x1db56bf994b37ae8e79f5ce000be1727a6060ae4eef24736b7cc999c3c020000";
+
+  const mockPrincipalExample5 = Principal.from(
+    "opspt-7okml-4664d-lqdny-uuuto-6nars-7am7t-jebvm-j3xj2-j4tdu-vqe",
+  );
+  const ethExample5 =
+    "0x1dca62f9ef706b80db8a5293779a08cbe067e69206ac4eee9d27931d2b020000";
+
+  const mockPrincipalExample6 = Principal.from(
+    "ezu3d-2mifu-k3bh4-oqhrj-mbrql-5p67r-pp6pr-dbfra-unkx5-sxdtv-rae",
+  );
+  const ethExample6 =
+    "0x1d882d15b09f8e81e29606305f5fefc5eff3e2309620a3557ecae39d62020000";
+
+  const mockPrincipalExample7 = Principal.from(
+    "47gy6-2c22d-voqoy-eflbe-gwml3-zwe52-r6lx7-rexro-ebluo-2rqcd-sae",
+  );
+  const ethExample7 =
+    "0x1d5ad0eae83b042ac243598bde6c4eea3e5dff125e2e2057476a3010e4020000";
+
+  const mockPrincipalExample8 = Principal.from("2chl6-4hpzw-vqaaa-aaaaa-c");
+  const ethExample8 =
+    "0x09efcdab00000000000100000000000000000000000000000000000000000000";
+
   it("should encode principal into fixed 32-byte representation suitable for calling Ethereum smart contracts", () => {
     expect(encodePrincipalToEthAddress(mockPrincipalExample1)).toEqual(
       ethExample1,
@@ -32,5 +60,25 @@ describe("minter-utils", () => {
     expect(encodePrincipalToEthAddress(mockPrincipalExample3)).toEqual(
       ethExample3,
     );
+
+    expect(encodePrincipalToEthAddress(mockPrincipalExample4)).toEqual(
+      ethExample4,
+    );
+
+    expect(encodePrincipalToEthAddress(mockPrincipalExample5)).toEqual(
+      ethExample5,
+    );
+
+    expect(encodePrincipalToEthAddress(mockPrincipalExample6)).toEqual(
+      ethExample6,
+    );
+
+    expect(encodePrincipalToEthAddress(mockPrincipalExample7)).toEqual(
+      ethExample7,
+    );
+
+    expect(encodePrincipalToEthAddress(mockPrincipalExample8)).toEqual(
+      ethExample8,
+    );
   });
 });