Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly broken tests? #563

Closed
crusso opened this issue Jul 25, 2024 · 0 comments · Fixed by #564
Closed

Possibly broken tests? #563

crusso opened this issue Jul 25, 2024 · 0 comments · Fixed by #564

Comments

@crusso
Copy link
Contributor

crusso commented Jul 25, 2024

Hi @chenyan-dfinity,

I was trying to manually port the spacebomb tests to Motoko (dfinity/motoko#4624), but these two are causing me difficulty and I wonder if the values actually have the expected type?

When I decode the values using didc decode they seem to start with a record. Is that expected? I wonder if the tests are trapping, but not for the right reason, but just because they are of the wrong type not because they require too many resources to decode.

assert blob "DIDL\04\6c\03\01\7f\02\01\03\02\6c\01\01\70\6c\00\6d\00\01\03\80\94\eb\dc\03" !: (vec record {null;record{reserved};record{}}) "zero-sized record (not ignored)";

assert blob "DIDL\03\6c\01\d6\fc\a7\02\01\6d\02\6c\00\01\00\80\ad\e2\04" !: (vec record {}) "vec record {} (not ignored)";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant