-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignites can't be broken into two blocks on the same day #6543
Comments
Oof. This could be tricksy. |
I think the key to this is going to be supporting different "talk" types, not just "talk". Right now we support talk, ignite, and workshop, but not everywhere (which has led to confusion). |
Ignites are just a special case, because they are a group of talks that takes up one space in the program. To do this, we'd have to add some capability of having "multi-items in one slot, called whatever you want" - so sorta like a rename-able section of the YAML where we just have Backwards compat will be super tough. |
I am looking at this again...I think that it would work pretty okay if it was something like this: program:
- title: "Ignites Round 1"
type: ignite
ignite-id: 1
date: 2019-08-27
start_time: "13:00"
end_time: "13:30"
- title: "Ignites Round 2"
type: ignite
ignite-id: 2
date: 2019-08-27
start_time: "16:00"
end_time: "16:30"
ignites:
- title: "veronica-hanus"
date: 2019-08-27
ignite-id: 1
- title: "jay-gordon"
date: 2019-08-27
ignite-id: 1
- title: "adam-shake"
date: 2019-08-27
ignite-id: 1
- title: "j-paul-reed"
date: 2019-08-27
ignite-id: 2
- title: "michael-stahnke"
date: 2019-08-27
ignite-id: 2
- title: "jason-yee"
date: 2019-08-27
ignite-id: 2 so when it is drawing ignites, there's a slightly different query; if the ignite program element has |
Looking at the old code, this won't be too hard. This is the thing that draws the ignite block:
So I think what we do is something like this:
|
I fixed this I theme 2.0 - you can dig into the details here - #9839 (comment) |
Fixes #6543 Signed-off-by: Matt Stratton <[email protected]>
I noticed when fixing #5338 that we didn't seem to be able to break the Ignite talks for one day up into two different blocks. We probably want to support this.
The text was updated successfully, but these errors were encountered: