-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Support negative weights #10
Comments
Hi, But, the current implementation does not really distinguish the weights based on positive or negative values, and setting negative weights should already work. I tried this quickly, and indeed, setting a negative value will lead to a lower score. Can you please test this, and tell me how else you would like this feature to behave? |
Yes, the negative scores seem to be taken into account but it is a bit funky. Consider the following two cases:
This makes it hard to filter out uninteresting articles. |
I think the simplest solution is removing the positive score checks in the score computation in filter.py. This then allows negative scores to add up. Unless there is a rationale for insisting in positive scores for each key? |
You are completely right. I hove overlooked, that the threshold I agree, negative scores should add up, I will implement this. |
I have fiddled with this locally and it seems to be working fine. I'm going to create a PR with what I have. I wonder if there are any UI changes that should go along with this? As you already mentioned highlighted text makes sense. Perhaps the articles in the "Other Entries" should also be sorted by (negative) score? |
Right now only positive values are supported by the filter. This is a request to support also negative values. The use case for this is filtering out keywords, authors, etc. that the user is not interested in.
The text was updated successfully, but these errors were encountered: