-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force non-empty profile name also on editing #2243
Comments
We use the TableView-based
So I'd opt in for the first way. WDYT? |
hm, are disabled "back" buttons a thing in ios? i cannot remember to have seen that somewhere. so, indeed a bit tricky for a minor thing. a 3rd option is to leave things as is, and adapt android :) let's sleep it over :) |
signal/whatsapp/telegram all go for cancel/done, partly delayed until things are really changed (eg. whatsapp shows a back button that changes to cancel/done on changes, not allowing empty profile name as well) |
otoh, i am a cancel/done would make avatar selection harder - code wise, but also UI wise as that suddenly needs to be cancelable as well - and user need to remember to hit "done" another time. might be okay, however, wondering if that all is worth the minor issue we try to fix here. what about the following: set the "placeholder" to the original name - and if the user "clears" the name, they'll notice that this is not possible as the original name is shown. when still hitting "okay", do not change the name if new name is empty. this will also result in a smart migration |
during onboarding, we enforce a profile name to be set.
for consistency, and as same reasons apply, we should not allow to clear the name later on editing.
there are old profiles where we did not have enforced a name on creation. we would enforce them now during editing, if eg. the user only wants to edit the "bio". however, that seems to be a minor, and also android does it that way since some time, without much complains or issues.
cmp deltachat/deltachat-android#3160, deltachat/deltachat-desktop#4042
The text was updated successfully, but these errors were encountered: