Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add predicateHints and jsonPredicateHints parameters to load_as_pandas methods #292

Open
ognis1205 opened this issue Apr 18, 2023 · 1 comment · May be fixed by #295
Open

Add predicateHints and jsonPredicateHints parameters to load_as_pandas methods #292

ognis1205 opened this issue Apr 18, 2023 · 1 comment · May be fixed by #295
Assignees
@chakankardb

Comments

@ognis1205
Copy link

Hi everyone,
I'm currently working on a code snippet to demonstrate the basics of Delta Sharing.
While working on this, I came across the following implementations:

After reviewing these implementations, it seems that the Python client library does not consider the JSON predicates public.
I think this feature should be public though, is there any reason why this feature is not treated as public?

Thanks.
@ognis1205 ognis1205 changed the title Add predicateHints and jsonPredicateHints parameters to load_as_*** methods Add predicateHints and jsonPredicateHints parameters to load_as_pandas methods Apr 20, 2023
@ognis1205
Copy link
Author

ognis1205 commented Apr 20, 2023 •
edited
Loading

I’ve already implemented this feature on my fork so if it is a reasonable feature request, I can make a PR. As for ‘load_as_spark’, I thought it would be better to treat it as another feature request, so I did not mention it, but I can handle it as well.

Thanks.

@ognis1205 ognis1205 linked a pull request Apr 27, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakankardb chakankardb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/add predicate hints and json predicate hints parameters ognis1205/delta-sharing
2 participants
@ognis1205 @chakankardb