Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review JSDuck comments throughout for accuracy and completeness. #102

Open
johnyanarella opened this issue Jun 27, 2013 · 2 comments
Open

Review JSDuck comments throughout for accuracy and completeness. #102

johnyanarella opened this issue Jun 27, 2013 · 2 comments
Assignees
@johnyanarella
Labels
enhancement in progress
Milestone
next minor (0.10.0)

Comments

@johnyanarella
Copy link
Member

No description provided.

@ghost ghost assigned johnyanarella Jun 27, 2013
@johnyanarella
Copy link
Member Author

NOTE Need to document the optional configuration object parameter syntax for Deft.Promise::then(), Deft.Promise::otherwise() and Deft.Promise::always().

@brian428
Copy link
Member

Since I've been slack lately (working on the TypeScript definition generator for Ext JS and Touch), I can go through the JSDuck comments if you like. I'm out of town this weekend so if you get the itch, feel free to tackle this. But if not, I can start on it early next week.

johnyanarella pushed a commit that referenced this issue Jun 28, 2013
Added JSDuck comments and units tests for Deft.Logger. Fixed bugs unc…
5bbf111 
…overed in new Deft.Logger unit tests.

The Ext JS log adapter implementation incorrectly attempted to use `is` instead of `=` for assignments, when adapting 'verbose' to 'info' and 'deprecate' to 'warn'.
Ext.Logger has transient availability in Sencha Touch - with a production build it will not be available unless explicitly included.  Revised the Sencha Touch log adapter implementation to accommodate this.
Added the Deft.Logger tests to the Karma configurations and manual test runner.

See #102
See #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnyanarella johnyanarella

Labels
enhancement in progress
Projects
None yet
Milestone
next minor (0.10.0)
Development

No branches or pull requests
2 participants
@brian428 @johnyanarella