feat: new metadata models endpoints #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naomi-lgbt
previously approved these changes
Aug 5, 2024
|
@naomi-lgbt @lukeocodes How close are we to getting this merged in? |
lukeocodes
force-pushed
the
lo/get-models-api
branch
from
7310d0d
to
59b06da
Compare
feat: new metadata models endpoints fix: some tests were hitting production feat: post-EA changes chore: update test to actually test the response body
lukeocodes
force-pushed
the
lo/get-models-api
branch
from
59b06da
to
d02045e
Compare
|
@naomi-lgbt or @dvonthenen if you could review/approve. I have updated the tests to actually check the response body as requested, and commits now squashed cc @jpvajda |
dvonthenen
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds new metadata get model endpoints to the JS SDK