feat: reconnect socket automatically on close event #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvonthenen
reviewed
Apr 25, 2024
| } | ||
|
|
||
| this._reconnections += 1; | ||
| this._unregisterEvents(); |
There was a problem hiding this comment.
Would the user be interested in getting the onopen event to know that the WS successfully reconnected?
There was a problem hiding this comment.
We reregister the events after. These internal events emit an external one, which won't need to be reregistered. So they're likely to get second onopen event... which may be troublesome for some actually
|
I need to get the key factory in and documented before this, and I may change this to be a method users can call rather than automatically reconnect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.