-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: one scene loading #1284
Draft
popuz
wants to merge
32
commits into
main
Choose a base branch
from
feat/one-scene-loading-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat: one scene loading #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ee6ace6.
# Conflicts: # Explorer/Assets/Scripts/Global/Dynamic/MainSceneLoader.cs
popuz
force-pushed
the
feat/one-scene-loading-2
branch
from
June 24, 2024 20:39
aeebd91
to
df706d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Close #1217
RealmPartitionSettings
/goto-local 5,7 only
/goto goerli 82,1 only
How to test the changes?
/goto goerli 82,1 only
and verify you get in Goerli with just 82,1 scene loaded./goto-local 77,1 only
and verify you are still in Goerli with just 77,1 scene loaded.tip: try to play with scenes loading radius in settings and verify it is not affecting when scene are loaded with
only
parameter from the chatNOTE: see previous check of this PR
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md