Add Config #2
Closed
Add Config #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonpombo8
reviewed
Aug 6, 2024
| @@ -0,0 +1,32 @@ | |||
|
|
|||
|
|
|||
| export enum GameIds { | |||
There was a problem hiding this comment.
what if intead of having this list here, that would require that every time we have a new game we need to make an update from the lib, we pass the game-id string to the library init ?
I'm already doing that and storing it in the Cache.config inside the sdk file.
And keep this config logic with the environments and server configs agnostic to the game ids
https://github.com/decentraland/sdk-mini-games/blob/main/src/index.ts#L9-L11
There was a problem hiding this comment.
// inside the library
const { config } = getSDK()
const GAME_ID = config.gameId
fetch(someEndpoint(GAME_ID))There was a problem hiding this comment.
thanks gon! i close this PR and create a new one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.