[Feature] Update ignore
behaviour for on_schema_change
to backfill nulls for removed columns, instead of failing
#10733
Labels
Is this your first time submitting a feature request?
Describe the feature
When a column is removed from an incremental model, and its
on_schema_change
behaviour is set toignore
, it should backfill a null instead of failing.@RatandeepSharma recently opened dbt-labs/docs.getdbt.com#5978 in the docs repo after being confused by
on_schema_change: ignore
failing when a column is removed. While investigating that, I tripped over dbt-labs/dbt-bigquery#1102 (comment), which proposed:I agree that we should make it so that ignore doesn't cause the job to fail, but I don't think we need a whole new
classic
option anymore. Since that comment in early 2023, we've added support for behaviour change flags. I think that instead of adding theclassic
option, we just change the default behaviour ofignore
to insert nulls and let people opt into the old behaviour if they depend on it.Describe alternatives you've considered
Still adding a new mode. But given our commitment to backwards compatibility, we'd need to keep
ignore
behaving the same way and come up with a new name for the new behaviour, otherwise we'd have to go through a behaviour change flag anyway.Who will this benefit?
People who don't want to drop a column after removing it from their model.
Are you interested in contributing this feature?
Not really, but it's incremental season right now so I bet someone could give it a gander!
Anything else?
No response
The text was updated successfully, but these errors were encountered: