Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String Flowable to InputStream bridge #12

Open
akarnokd opened this issue Mar 22, 2018 · 3 comments
Open

String Flowable to InputStream bridge #12

akarnokd opened this issue Mar 22, 2018 · 3 comments

Comments

@akarnokd
Copy link

Hi.

I took on the challenge of writing a bridge that turns Strings in a Flowable into bytes readable via the Java InputStream API (blockingly):

Since I don't do I/O in RxJava2Extensions, I'd like to ask if this project would be interested in this type of bridge?

@davidmoten
Copy link
Owner

I like it. I'd be glad to give it a home, thanks. I'll have a think what to name it (Strings.createInputStream(Flowable<String>, Charset) perhaps, or Strings.toInputStream).

davidmoten added a commit that referenced this issue Mar 23, 2018
@davidmoten
Copy link
Owner

Oh I just copied and pasted then fixed for Java 6. Would have been more polite to see if you wanted to make a PR (and good for the commit history to see who wrote what). Happy to roll change back for a PR if you want.

@akarnokd
Copy link
Author

I'm fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants