Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video: Handle a 'subStart' of 0 #200

Open
david-allison opened this issue Apr 19, 2024 · 0 comments
Open

Video: Handle a 'subStart' of 0 #200

david-allison opened this issue Apr 19, 2024 · 0 comments

Comments

@david-allison
Copy link
Owner

But more complexity, needs to handle line highlighting, but NOT if the video never loaded

Index: CorpusSearch/ClientApp/src/components/ComparisonTable.tsx
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/CorpusSearch/ClientApp/src/components/ComparisonTable.tsx b/CorpusSearch/ClientApp/src/components/ComparisonTable.tsx
--- a/CorpusSearch/ClientApp/src/components/ComparisonTable.tsx	(revision 17233ab8a048b09f9682137653e14679004a087f)
+++ b/CorpusSearch/ClientApp/src/components/ComparisonTable.tsx	(date 1713493030239)
@@ -186,7 +186,7 @@
                             return <Fragment key={response.title + line.csvLineNumber.toString()}>
                                 <tr key={line.date} style={getLineStyle(line)}>
                                 {isVideo && <td style={{cursor: "pointer"}} onClick={() => {
-                                    if (line.subStart && player.current) {
+                                    if (line.subStart != undefined && player.current) {
                                     player.current.seek(line.subStart)
                                 }
                                 }}>▶️</td>}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant