Fix: When a Leader starts up, it should re-apply all logs #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a node starts up as the Leader, it now re-applies all logs at once. Previously: - New Leader only updated IO progress - Committed log ID remained unchanged Now: - New Leader updates IO progress - Triggers update of committed log ID - Fix: databendlabs#1246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fix: When a Leader starts up, it should re-apply all logs
When a node starts up as the Leader, it now re-applies all logs at once.
Previously:
Now:
New Leader updates IO progress
Triggers update of committed log ID
Fix: Missing log replay on single-node restart (bug?) #1246
This change is