{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":19352450,"defaultBranch":"develop","name":"dash","ownerLogin":"dashpay","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2014-05-01T17:45:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/11511719?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1723033416.0","currentOid":""},"activityList":{"items":[{"before":"8e32dd80d44f81d6b2c902cf2f0959058ab4d3ed","after":"3b9f9352a19822602ef944cb7815b94015dc2d00","ref":"refs/heads/develop","pushedAt":"2024-09-27T17:49:45.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6293: backport: cmake prereqs 1\n\n801c4fc24a1493c211022f2dde48892c6fae3f3f build: followup to 29488 applied to gmp (pasta)\n4b704a60ad31913f5d6f1ed5f8b735204bf6ab6c Merge bitcoin/bitcoin#28627: depends: zeromq 4.3.5 (fanquake)\n0e6cb989a70a505539122fbc0a7c6d79d60632ca Merge bitcoin/bitcoin#26421: build: copy config.{guess,sub} post autogen in zmq package (fanquake)\ncd33b69bfdee7d52ea9c291e471ab6f7cd4bfc75 Merge bitcoin/bitcoin#29488: depends: always configure with `--with-pic` (fanquake)\n1b88674815ef958c3a407849e3f247c9f3c5d242 Merge bitcoin/bitcoin#29287: depends: Do not override `CFLAGS` when building SQLite with `DEBUG=1` (fanquake)\nf50fb6e627bdd58821944c9637638dfaa9ff81a5 Merge bitcoin/bitcoin#26998: depends: ensure we are appending to sqlite cflags (Andrew Chow)\n25a594f46e80851fd68f8c825320ada3db63bd04 Merge bitcoin/bitcoin#25987: build: compile depends sqlite with more recommended options (Andrew Chow)\nd725c5880d1ebb573b3fa72235ff0a5e1657f194 Merge bitcoin/bitcoin#27312: depends: qrencode 4.1.1 (fanquake)\n482e5bbc49a82ba16ca4c3e19a6c4aaf4ff056bb Merge bitcoin/bitcoin#27462: depends: fix compiling bdb with clang-16 on aarch64 (fanquake)\nf0a53c99e9b23bbe8c7665d4f40eafb5f7b46330 Merge bitcoin/bitcoin#26994: depends: define `__BSD_VISIBLE` for FreeBSD bdb build (merge-script)\nb1ac9926e74e7d5649882db6d71b5a217c1457cc Merge bitcoin/bitcoin#26073: build: fix depends bdb compilation for BSDs (fanquake)\n45e0f6e56d1f9441f6d832619f33db0af8afcc38 Merge bitcoin/bitcoin#25763: bdb: disable Werror for format-security (fanquake)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n First batch of PRs which lead towards cmake, focusing on having nothing or very little done out of order / with significant conflicts\n\n ## What was done?\n batch of 11 backports which lead towards cmake\n\n ## How Has This Been Tested?\n Built locally, seems to work, let's see CI\n\n ## Breaking Changes\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 801c4fc24a1493c211022f2dde48892c6fae3f3f\n knst:\n utACK 801c4fc24a1493c211022f2dde48892c6fae3f3f\n\nTree-SHA512: b8b5299da9d82ab485ba5141ea12ba5c606f1a783b34c957d61e0a68d45865754fbc8bcbb0c5eabe3d410ff6262ce26789cf4a3af696905f7b7908e523c97816","shortMessageHtmlLink":"Merge #6293: backport: cmake prereqs 1"}},{"before":"bd27f6560101f6b25796d0ff3aeef4cf20c0f758","after":"8e32dd80d44f81d6b2c902cf2f0959058ab4d3ed","ref":"refs/heads/develop","pushedAt":"2024-09-27T17:29:12.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6220: backport: Merge bitcoin#18448,24433, 24139, 23001, (partial) 24339, (partial) core/gui#420\n\n1a12ef14dac4fed75aab5cc140ea1dfbdf89841a (partial)Merge bitcoin-core/gui#420: Ensure translator comments end in full stop (Hennadii Stepanov)\nd891d3c95cc539da62a7fd98d876cc9eb64820b6 (partial) Merge bitcoin/bitcoin#24339: rpc: Improve RPC help by explicitly mentioning output types (MarcoFalke)\n237279950b3f0cf246d5ac1710fbd1f041c7e276 Merge bitcoin/bitcoin#23001: doc: Enable TLS in links in documentation (fanquake)\ne4c8ea5061c7775869d1328f30e019cf8764c897 Merge bitcoin/bitcoin#24139: Avoid unsigned integer overflow in bitcoin-tx (MarcoFalke)\n98f7e82d07182d3caaacd1f3330f3b8cd84559a4 Merge bitcoin/bitcoin#24433: doc: Explain that feedback needs to be addressed (fanquake)\na3a4f633154d8b8f221b656f2db4386816d34f33 Merge bitcoin/bitcoin#18448: rpc: fix/add missing RPCExamples for \"Util\" RPCs (MarcoFalke)\n\nPull request description:\n\n btc backports\n\nACKs for top commit:\n PastaPastaPasta:\n utACK 1a12ef14dac4fed75aab5cc140ea1dfbdf89841a\n\nTree-SHA512: 4e3c4414d4db6ea355c336a9a6b30a26b628b607cbac51b7e17366cc1e6e8ba0aeb8af88529d018107482bdfb60bbd12b6d66e8acaaa1d6b21b4b06e0929b899","shortMessageHtmlLink":"Merge #6220: backport: Merge bitcoin#18448,24433, 24139, 23001, (part…"}},{"before":"9272ae24ac79ac3566a713f53e00a5edf0795b5e","after":"bd27f6560101f6b25796d0ff3aeef4cf20c0f758","ref":"refs/heads/develop","pushedAt":"2024-09-27T15:47:35.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6284: backport: bitcoin#21713, #21856, #22061, #22122, #22172, #22261, #22381, #22445, #22447\n\n8f06ac9dfac3fcc04b541e7ca6cf8794fb9017d3 Merge bitcoin/bitcoin#22172: doc: update tor.md, release notes with removal of tor v2 support (W. J. van der Laan)\n9b22501a4d491254fb0a5f86bc8bf2eff1a72d3a Merge bitcoin/bitcoin#22122: ci: Bump macOS image to big-sur-xcode-12.5 (MarcoFalke)\n3b05a99b505ac80518776c0ffeaa35f62e93ca11 Merge bitcoin/bitcoin#22106: refactor: address ProcessNewBlock comments from #21713 (fanquake)\nc8725560c9d523e42736b42ea3702f105e2144f6 Merge bitcoin/bitcoin#21856: doc: add OSS-Fuzz section to fuzzing.md doc (MarcoFalke)\nfacf685285671576eac9f84639049330a207ef75 Merge bitcoin/bitcoin#22261: [p2p/mempool] Two small fixes to node broadcast logic (fanquake)\n1430897fc4aa15b6e95d3ae92919caf267845a06 Merge bitcoin/bitcoin#22445: fuzz: Move implementations of non-template fuzz helpers from util.h to util.cpp (MarcoFalke)\nf0c62d50a5da4e7afe5d5777bbe4e33d8b6a009b Merge bitcoin/bitcoin#22447: test: whitelist rpc_rawtransaction peers to speed up tests (fanquake)\nb60951414220d3b654d6582a51088d0deb0e4f93 Merge #22381: guix: Test security-check sanity before performing them (Carl Dong)\n9ef68d1905ed961b0a3cfac142f3de8b40382749 Merge bitcoin/bitcoin#22061: ci: Bump multiprocess memory (fanquake)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Regular backports from bitcoin v22\n\n ## What was done?\n See commits\n\n ## How Has This Been Tested?\n Run unit and functional tests\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 8f06ac9dfac3fcc04b541e7ca6cf8794fb9017d3\n PastaPastaPasta:\n utACK 8f06ac9dfac3fcc04b541e7ca6cf8794fb9017d3\n\nTree-SHA512: f800b7ca8d357f2d02ce5cb1fc4951c2765242676c5494efd5e22e8f6d41d889e1fa2f888930f72aded75813413c6488d8a7d96baa2cf4820e3461464708658e","shortMessageHtmlLink":"Merge #6284: backport: bitcoin#21713, bitcoin#21856, bitcoin#22061, b…"}},{"before":"750475ffaa2fb5ef2ebf4cc0091b1016227a1ff4","after":"9272ae24ac79ac3566a713f53e00a5edf0795b5e","ref":"refs/heads/develop","pushedAt":"2024-09-27T15:35:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6209: chore: deprecate an option `platform-user` in favour of whitelist\n\ne2c66ae3e9eef0d59cbd2f509bad25292b9ee66f chore: deprecate a setting platform-user in favour of whitelist (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Hard-coded restrictions for platform-user are super-seeded by whitelist feature.\n\n ## What was done?\n Before actually removing feature, let's make it deprecated for now\n Split from https://github.com/dashpay/dash/pull/6105/\n 6105 - to close and re-open for next major release.\n\n It deprecates old command line argument `-platform-user` by renaming to `-deprecated-platform-user`\n\n ## How Has This Been Tested?\n See new 2 functional tests: `rpc_deprecated_platform_filter.py` and `rpc_external_queue.py` which are split from `rpc_platform_filter.py`\n\n ## Breaking Changes\n Command line argument `-platform-user` is renamed to `-deprecated-platform-user`\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK e2c66ae3e9eef0d59cbd2f509bad25292b9ee66f\n PastaPastaPasta:\n utACK e2c66ae3e9eef0d59cbd2f509bad25292b9ee66f\n\nTree-SHA512: c237065304f5ba682bc381a202a17e1b7191bb02ba5e51d8eec3170315ee980e0c20fd3b6aa6d77f75095c1761d374a7139ef289b0c78d74809b233f15a1a04a","shortMessageHtmlLink":"Merge #6209: chore: deprecate an option platform-user in favour of …"}},{"before":"9b21aef29eaf4beac5120f23db55187eb50b9e4f","after":"750475ffaa2fb5ef2ebf4cc0091b1016227a1ff4","ref":"refs/heads/develop","pushedAt":"2024-09-27T01:20:19.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6285: backport: bitcoin-core/gui#29, gui#123, #164, gui#256, gui#309, gui#313, gui#329, gui#331, gui#333, gui#346, gui#393\n\n6431f71b3a16339d8a88f3ac123cd9a6a057ae42 Merge bitcoin-core/gui#393: Fix regression in \"Encrypt Wallet\" menu item (Hennadii Stepanov)\nfc900a8aea56a5cf3582bd6e29aeb5ca5d7f3a30 Merge bitcoin-core/gui#333: refactor: Signal-slot connections cleanup (Hennadii Stepanov)\n9ca2aad0b37031f8a75b68a8a4b559afc1aa98ed Merge bitcoin-core/gui#164: Handle peer addition/removal in a right way (Hennadii Stepanov)\n7d9ce32562837a9ae9f63e7ed37c9fb24cd60c0b Merge bitcoin-core/gui#29: refactor: Optimize signal-slot connections logic (Hennadii Stepanov)\n3be79a9ed9623b7579ec296e0118c153cd9f2d4c Merge bitcoin-core/gui#256: Save/restore column sizes of the tables in the Peers tab (Hennadii Stepanov)\nf4fccd31cb1879b9772b98e730bb499c25298af5 Merge bitcoin-core/gui#329: Make console buttons look clickable (Hennadii Stepanov)\n5a0d524506acfc7907bf3bf3649ff6bd2f191fea Merge bitcoin-core/gui#123: rpc: Do not accept command while executing another one (Hennadii Stepanov)\n19310646e0953f179ffaa9ebd6f0b29305b549fd Merge bitcoin-core/gui#331: Make RPC console welcome message translation-friendly (Hennadii Stepanov)\n69a1305978a65978feae17e1a5715b4b70f82e91 Merge bitcoin-core/gui#309: Add access to the Peers tab from the network icon (Hennadii Stepanov)\nc858325d409ac851eb708b4be6b160f9c8420841 Merge bitcoin-core/gui#346: English translations update (Hennadii Stepanov)\n412445afb52973eaef11875b286885761501f1ea Merge bitcoin-core/gui#313: qt: Optimize string concatenation by default (W. J. van der Laan)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Gui related backports from bitcoin v22\n\n ## What was done?\n See commits\n\n ## How Has This Been Tested?\n Run unit/functional tests\n\n See also:\n\n \"right\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n light ACK 6431f71b3a16339d8a88f3ac123cd9a6a057ae42\n PastaPastaPasta:\n utACK 6431f71b3a16339d8a88f3ac123cd9a6a057ae42\n\nTree-SHA512: bb14de71c9375b10da695db6c521c26686815b8b5ca2748bfe3bd2eafa9d332acd60acd85a1f2eed3aa831d16e5741ecc7570130ce9cf5bff011c065b55d62b2","shortMessageHtmlLink":"Merge #6285: backport: bitcoin-core/gui#29, gui#123, #164, gui#256, g…"}},{"before":"d8da09401d8ce0355da277084d950100b48173a1","after":"9b21aef29eaf4beac5120f23db55187eb50b9e4f","ref":"refs/heads/develop","pushedAt":"2024-09-27T01:12:56.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6269: feat: improvements for v19, v20 and dip3 - fire up test chains by first block 5/n\n\n603061141fed223d1078df223db44d5f274d3355 style: apply clang format for new changes (Konstantin Akimov)\nf01338f6076f1f817aabc09dcac97a08f0cd3d09 feat: drop requirement of v20 for Asset Unlock transactions (Konstantin Akimov)\nb3e9e5c981e40277aad42d1e9b5f94948bdaf045 feat: drop v20 requirement for special EHF transaction (Konstantin Akimov)\n8639298e169633c9567c761696258834604aea10 refactor: drop fast_dip3_enforcement=True from functional tests. (Konstantin Akimov)\n0add6bc82390834ade99a63dd9bfefe5ad76c1f1 feat: removed 2 checkpoints: TestChainDIP3Setup and TestChainV19Setup from unit tests (Konstantin Akimov)\n3fffb0cab90a5db135400c9ff63e0d1075a50dca refactor: moves evo-deterministicmns_tests specific code from header (Konstantin Akimov)\n1d96fbf091ee9906cf8bd46fde22c40bc160e8b2 feat: let asset-unlock transactions be available since v20 on all networks (Konstantin Akimov)\n4b4001bbe774a8ca045bf78fafe4ee5a3fd119af perf: activate v20 on the same block as v19 for Reg Test (Konstantin Akimov)\ne0d97cf7aca2fd6cbcfa85d642fbe2d417761a67 feat: let asset locks be mined before v20 (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n This PR is 5th in the achieving ultimate goal to activate old forks from block 1.\n It helps to run unit and functional tests faster; it helps for platform's dev-environment to start faster.\n\n ## What was done?\n - v20 on RegTest is activated from same block as v19 (height 1200 changed to 900)\n - relaxed condition for special transactions Asset Lock (can be mined any block so far as v20 is activated long time ago).\n - unify code for regtest, mainnet, testnet for Asset Unlock validation\n - removed 2 checkpoints: TestChainDIP3Setup and TestChainV19Setup from unit tests which make further changes for forks easier\n - enforced flag `fast_dip3_enforcement=True` from functional tests which is always true\n\n ## How Has This Been Tested?\n Run unit and functional tests\n\n `tsan` job runs 500 seconds faster of real time and 2000seconds faster for \"accumulated time\"\n https://gitlab.com/dashpay/dash/-/jobs/7817453421 - this PR\n https://gitlab.com/dashpay/dash/-/jobs/7805625816 - some old PR for reference\n\n No breakdown per tests here, because they affect each other and runs in parallel.\n\n ## Breaking Changes\n Regtest has v20 activated on same block as v19 if otherwise is not specified with `-testactivationheight=v20@1200`\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 603061141fed223d1078df223db44d5f274d3355\n PastaPastaPasta:\n utACK 603061141fed223d1078df223db44d5f274d3355\n\nTree-SHA512: 5a1e15a32931682240ecd8e5bab8a0bba67eebf0409ea7b7556018240c48d59ec8daab8859a2fb883154aac95813553c2835a0527269fcf4e81f1edb1b2ed0ac","shortMessageHtmlLink":"Merge #6269: feat: improvements for v19, v20 and dip3 - fire up test …"}},{"before":"c200175ebf76fb6fe36560fd1bb02073cd6a7304","after":"d8da09401d8ce0355da277084d950100b48173a1","ref":"refs/heads/develop","pushedAt":"2024-09-26T22:39:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6247: feat: drop deprecated protx *_hpmn RPC entry points in favor of protx *_evo\n\n6f0b546fc2cf1be92cae89297486642c7ad87e42 feat: drop deprecated protx_*_hpmn RPC entry points in favor of protx_*_evo (Konstantin Akimov)\n\nPull request description:\n\n ## What was done?\n\n Drop deprecated protx *_hpmn RPC entry points in favor of protx *_evo\n\n Full list of removed composite RPC:\n\n - protx register_fund_hpmn\n - protx register_hpmn\n - protx register_prepare_hpmn\n - protx update_service_hpmn\n\n ## How Has This Been Tested?\n **platform still uses it, need to replace `_hpmn` suffixes to `_evo` and remove -deprecated_hpmn from dash.conf**\n\n shumkov please be notified that mentioned RPC are going to be removed in Dash Core v22 as deprecated, this PR requires your approval\n\n ## Breaking Changes\n Removed RPC:\n - protx register_fund_hpmn\n - protx register_hpmn\n - protx register_prepare_hpmn\n - protx update_service_hpmn\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 6f0b546fc2cf1be92cae89297486642c7ad87e42\n PastaPastaPasta:\n utACK 6f0b546fc2cf1be92cae89297486642c7ad87e42\n\nTree-SHA512: 6667c34da5e9879b0d0bc326f6e42de4ee886c3b3e61fe4e76e80e3dbd16a8e27aa98435465ba9e41d5097557d2f924948031b0fe5099121b742106d45869426","shortMessageHtmlLink":"Merge #6247: feat: drop deprecated protx *_hpmn RPC entry points in f…"}},{"before":"67b5d86d8c38d4fa618d81754d2bf107cab18fb8","after":"c200175ebf76fb6fe36560fd1bb02073cd6a7304","ref":"refs/heads/develop","pushedAt":"2024-09-26T17:32:29.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"knst","name":"Konstantin Akimov","path":"/knst","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/545784?s=80&v=4"},"commit":{"message":"Merge #6250: backport: Merge bitcoin#22217, 23025, 22362\n\nbd67f806343314962198b463758f7dca3fd56d54 Merge bitcoin/bitcoin#22362: Drop only invalid entries when reading banlist.json (W. J. van der Laan)\n8b3a4867027f2d637107972c8736d0944f2775a1 Merge bitcoin/bitcoin#23025: bench: update nanobench add `-min_time` (W. J. van der Laan)\nd7a20b3ee6882049858a958f2e32efa85978eb93 Merge bitcoin/bitcoin#22217: refactor: Avoid wallet code writing node settings file (Samuel Dobson)\n\nPull request description:\n\n btc backport\n\nACKs for top commit:\n knst:\n utACK bd67f806343314962198b463758f7dca3fd56d54\n UdjinM6:\n utACK bd67f806343314962198b463758f7dca3fd56d54\n\nTree-SHA512: c487760c7b4946c21103978625076dd276344c831e99452031fae9b5c6cf954a1a0d3109725ab10f3d6837a5fd1833886a7e28c88b28429c6638c82f06f54f3d","shortMessageHtmlLink":"Merge #6250: backport: Merge bitcoin#22217, 23025, 22362"}},{"before":"85764c4b73bbe22c4d522e31c6b27db1f22725cf","after":"67b5d86d8c38d4fa618d81754d2bf107cab18fb8","ref":"refs/heads/develop","pushedAt":"2024-09-26T17:00:23.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"knst","name":"Konstantin Akimov","path":"/knst","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/545784?s=80&v=4"},"commit":{"message":"Merge #6287: test: fixes and improvements for `feature_llmq_simplepose.py`\n\na656d2f14f7f44609787b9ee10ae069a9b8dac97 feat: more logging (UdjinM6)\ncedd3d52be677f4c145504c35b919ee8bd109908 refactor: make expected_connections optional (UdjinM6)\nfd2fbe06a324ef4e119d7a36432524b5cd2fa438 fix: check mn state after each mined quorum (UdjinM6)\ncce87a662a04844b37fe4963325af5868f66fb0f fix: should have at least 2 connections when testing isolate_mn (UdjinM6)\n793f4b739f1a44b0408c36980f85e06f607333aa fix: connect repaired mns only (UdjinM6)\n8597acd0dcd2ee4e6e8476611130879d9ab3dd7e fix: remember mns that don't listen and avoid them (UdjinM6)\n206962575988c80f9254aa045293bf7a490090ab fix: calculate expected_complaints correctly (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Fix some general mistakes and also `connect_nodes` related issues discovered while debugging #6276. Add some logging to make debugging a bit easier.\n\n ~NOTE: builds on top of #6278 to avoid conflicts, will rebase~ done\n\n ## What was done?\n pls see individual commits\n\n ## How Has This Been Tested?\n run tests\n\n ## Breaking Changes\n n/a\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n kwvg:\n LGTM, ACK a656d2f14f7f44609787b9ee10ae069a9b8dac97\n knst:\n ACK a656d2f14f7f44609787b9ee10ae069a9b8dac97\n PastaPastaPasta:\n utACK a656d2f14f7f44609787b9ee10ae069a9b8dac97\n\nTree-SHA512: 30f657218ce0338f9a5a09d9a839cca9c4605740265d2182a1e143ec6ece739fecf748f7b60ccec065c17d9f6d893c0c47893be05c44bb8d34624fb4bf3c2a58","shortMessageHtmlLink":"Merge #6287: test: fixes and improvements for `feature_llmq_simplepos…"}},{"before":"4e72902474cb5eea72bd5d6d1424d76e5f4d9ec2","after":"85764c4b73bbe22c4d522e31c6b27db1f22725cf","ref":"refs/heads/develop","pushedAt":"2024-09-25T23:27:56.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6286: feat(rpc): introduce and use `setmnthreadactive` (regtest-only)\n\n1e17b7420785a0f92ce512167c2bce59b08538df test: no longer connect nodes in parallel in `start_masternodes` (UdjinM6)\nbe72ef5592635c13afdd497f05c15f46e987e550 test: use `setmnthreadactive` to get controlable `connect_nodes` behaviour (UdjinM6)\ne2ed82a7ae8949ab16e3aeb4d9a8d3ccb0d81d4b feat(rpc): introduce `setmnthreadactive` (regtest-only) (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n This adds a new rpc command to enable/disable automatic masternode connections creation. We need this for #6276. 1e17b7420785a0f92ce512167c2bce59b08538df is extracted from https://github.com/dashpay/dash/pull/6276/commits/ede1833ba442617c5efc77de64df6401102d16e7 to avoid multiple jobs calling `setmnthreadactive` on the same node in parallel.\n\n ## What was done?\n Add `setmnthreadactive` rpc and use it\n\n ## How Has This Been Tested?\n run tests\n\n ## Breaking Changes\n n/a\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n kwvg:\n LGTM, ACK 1e17b7420785a0f92ce512167c2bce59b08538df\n PastaPastaPasta:\n utACK 1e17b7420785a0f92ce512167c2bce59b08538df\n\nTree-SHA512: 83c1c07d0066e26202fd21942a09e41c3560c4d32229b44390946c4acb22319b32aa61a13b9106d20fc8cc197dd2a8ab5fdfcfdeaf3da76af062fc0fd7646972","shortMessageHtmlLink":"Merge #6286: feat(rpc): introduce and use setmnthreadactive (regtes…"}},{"before":"61201b80da4c7aa8287b938b1c8b49dadd14aee4","after":"4e72902474cb5eea72bd5d6d1424d76e5f4d9ec2","ref":"refs/heads/develop","pushedAt":"2024-09-25T17:24:08.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6245: backport: bitcoin#18275, #20220, #20305, #20410, #20426, #20573, #21083, #21201, #21786, #21787 (fee backports)\n\nd6946aaba1550f1f2e81a965f8ec4be1604e1f3a fix: offset fee for 1 duff in commission in wallet_basic.py due to missing bitcoin/bitcoin#22949 (Konstantin Akimov)\n3ba99b9c42b581105b5ba09dda65ec2abf65a8d4 Merge bitcoin/bitcoin#21786: wallet: ensure sat/vB feerates are in range (mantissa of 3) (MarcoFalke)\n22435f1898b1468b623e61e9574d071c88c4ac2c Merge bitcoin/bitcoin#21787: test: fix off-by-ones in rpc_fundrawtransaction assertions (W. J. van der Laan)\nccac35c89c19a20273b1aba5ebb6c4754d533286 Merge #21083: wallet: Avoid requesting fee rates multiple times during coin selection (Samuel Dobson)\n9e9975f83b9635955f8d022004c6de584cc897eb Merge #21201: rpc: Disallow sendtoaddress and sendmany when private keys disabled (Samuel Dobson)\n5ad8a489a5fc6f1ef2acb9f297ea325a81866cae Merge #20573: wallet, bugfix: allow send with string fee_rate amounts (MarcoFalke)\ndb4a2169bb0057145a3d86a458e7e2f27ecc7b73 Merge #20410: wallet: Do not treat default constructed types as None-type (MarcoFalke)\n01e41aa1fb40a1185f9e36c4c5c06036e54c9b83 Merge #20426: wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes (MarcoFalke)\nf436c20bc44197b3c99c7b74eedab20fb6f3f17c Merge #20305: wallet: introduce fee_rate sat/vB param/option (MarcoFalke)\n0fa19226cb04e6599ca37ff15e9e36236489ff23 Merge #20220: wallet, rpc: explicit fee rate follow-ups/fixes for 0.21 (Samuel Dobson)\nd530b7301638a768412acc32db6db4e04754e5d4 Merge #18275: wallet: error if an explicit fee rate was given but the needed fee rate differed (MarcoFalke)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Just regular backports from bitcoin v0.21, v22; mostly wallet+fee related\n\n ## What was done?\n - bitcoin/bitcoin#18275\n - bitcoin/bitcoin#20220\n - bitcoin/bitcoin#20305\n - bitcoin/bitcoin#20426\n - bitcoin/bitcoin#20410\n - bitcoin/bitcoin#20573\n - bitcoin/bitcoin#21201\n - bitcoin/bitcoin#21083\n - bitcoin/bitcoin#21787\n\n ## How Has This Been Tested?\n Run unit and functional tests\n\n ## Breaking Changes\n Some wallet rpc (sendtoaddress, sendmany, send) have a new argument `fee_rate` which is inserted before `verbose`.\n Release notes will be provided in a new PR once scope of backports and fixes in this PR is finalized by merging it to develop/\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK d6946aaba1550f1f2e81a965f8ec4be1604e1f3a\n PastaPastaPasta:\n utACK d6946aaba1550f1f2e81a965f8ec4be1604e1f3a\n\nTree-SHA512: 8826e1453fe84e3d21f789fab62c23ea13299ce13a7bf1132f70831c3255e823437b6ddd63f69a8e8a0dae95a2638a4454d727e91177b53a5d331872528b92e8","shortMessageHtmlLink":"Merge #6245: backport: bitcoin#18275, bitcoin#20220, bitcoin#20305, b…"}},{"before":"62e8d3399fd208cdbae2d637025de96439d8554c","after":"61201b80da4c7aa8287b938b1c8b49dadd14aee4","ref":"refs/heads/develop","pushedAt":"2024-09-25T14:34:25.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6278: perf: reduced delays and syncs in functional tests to run faster\n\n874ef8cda231eebde408263874a28e465de50bb6 fix: mine_quorum_no_checks -> mine_quorum_less_checks: do some checks to make sure quorums are mined correctly (UdjinM6)\n4f636f47b419877c5e09a3e6485eea451510733b fix: re-order functional tests: move governance to 60+seconds category (Konstantin Akimov)\nfe49f3f17881bb9e6e2f223de52688843f621e87 refactor: removed dead and commented code from test_framework.py (Konstantin Akimov)\ncd1958c82a20ba6219fd8748c16dfc586ba785c7 perf: removed sleep(6) from mine_cycle_quorum in functional tests (Konstantin Akimov)\n3f17a01a83bc7928d746209741f806c8a66f9574 fix: bump mocktime in simplepose when generating blocks to improve robustness (Konstantin Akimov)\n132d95e651e5737831461e066c4e4f46e8a56c26 perf: remove sleep(1) from each step of quorum creation in functional tests (Konstantin Akimov)\n4c57ad1c050ca27c0ff356afbb7c26a9a3d52141 chore: increase batch size from 10 to 50 for faster block generation in functional tests (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Functional tests take too long time to run.\n\n (PR is recreated from https://github.com/dashpay/dash/pull/6268 because CI is broken)\n\n ## What was done?\n - increased robustness `feature_llmq_simplepose.py` by adding missing bump for mocktime during block generations\n - removed sleep(1) from each stage of mine_quorum\n - removed sleep(6) from final stage of mine_cycled_quorum\n - size of batch for block generation in `feature_asset_locks.py` and in `activate_fork_by_name()` increased from 10 blocks to 50 blocks\n - moved governance's functional tests to \"60 seconds+\" category because they always the last one to wait if running more than 10 jobs at once\n Plus extra refactoring which removes dead and commented code from test_framework.py\n\n ## How Has This Been Tested?\n Locally, the functional tests speed up with these fixes for 15% for overall time and 20% for accumulated time\n `test/functional/test_runner.py -j20`\n\n Before:\n ```\n ALL | ✓ Passed | 7860 s (accumulated)\n Runtime: 481 s\n ```\n\n After:\n ```\n ALL | ✓ Passed | 6237 s (accumulated)\n Runtime: 416 s\n ```\n\n ---\n CI tsan job speeds up for 5 minutes in absolute time (~5%) and 1000 seconds in accumulated time.\n ```\n ALL | ✓ Passed | 23854 s (accumulated)\n Runtime: 6249 s\n ```\n ↑ [old version](https://gitlab.com/dashpay/dash/-/jobs/7822664869) vs [new version](https://gitlab.com/dashpay/dash/-/jobs/7825461091) ↓\n ```\n ALL | ✓ Passed | 22901 s (accumulated)\n Runtime: 5962 s\n ```\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 874ef8cda231eebde408263874a28e465de50bb6\n PastaPastaPasta:\n utACK 874ef8cda231eebde408263874a28e465de50bb6\n\nTree-SHA512: 514fa2fb32abd59c90f63b68fccc8c3d3b6d16b0b6ad7459c4a348825815e7d3012177565dea1f70b8a1f28ede1a297f91361365454d1be85955e77260451cf5","shortMessageHtmlLink":"Merge #6278: perf: reduced delays and syncs in functional tests to ru…"}},{"before":"0a9a83fa4ffea4b7d6d58e2f398ebb37fb1a4201","after":"62e8d3399fd208cdbae2d637025de96439d8554c","ref":"refs/heads/develop","pushedAt":"2024-09-25T14:18:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6184: chore: bump version in core to v22\n\n32ef5f8675d40198f06836a31c8f97ea7d1c115b chore: bump version in core to v22 (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Platform is requesting https://github.com/dashpay/dash/pull/6183 be merged into develop, so that they can stop using hacky custom builds (which end up being out of date).\n\n ## What was done?\n Bump version to v22.0, allow for breaking changes to be merged in. My plan here is to basically have v22.0 be what v21.1 would have originally been, a large minor version, however now, we can merge in breaking changes too.\n\n Breaking changes can now be merged in\n\n I don't have a firm timeline yet, but I want this optional smaller v22 to be released relatively quickly compared to normal major versions.\n\n ## How Has This Been Tested?\n NA\n\n ## Breaking Changes\n None, yet!\n\n ## Checklist:\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK 32ef5f8675d40198f06836a31c8f97ea7d1c115b\n UdjinM6:\n utACK 32ef5f8675d40198f06836a31c8f97ea7d1c115b\n\nTree-SHA512: 5695c076f4fc5666300492f734dd1ef860a6c7cbbfc7647dfb998c6a2188fddbe69f11c38b8f26b82d6711ef0ccb19d64cf2f6768035800f74120aa271eed4ad","shortMessageHtmlLink":"Merge #6184: chore: bump version in core to v22"}},{"before":"52928c548e2f72895aa177dd4b6ae98d7903d9f4","after":"0a9a83fa4ffea4b7d6d58e2f398ebb37fb1a4201","ref":"refs/heads/develop","pushedAt":"2024-09-25T14:08:39.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6282: refactor: drop some of circular dependencies over dkgsession\n\n74a5a9f98448ab59204296b4082c3598912b15ff style: apply clang-format (Konstantin Akimov)\ndb9798f5e44d3957e90bc13a1e55e9951f9621fe refactor: move call GetQuorumMembers inside Init() (Konstantin Akimov)\n95935668022ebd9a034b6289eb70ba837af3ca93 refactor: move pQuorumBaseBlockIndex from Init() to constructor in CDKGSession (Konstantin Akimov)\n9f3eb6bbb80e6536f29ee6c2379969d2b8903a30 perf: check DIP0003 before CDKGSession initialization (Konstantin Akimov)\n7f815cb5017bd223e7aec0645645d9ceeaf956d8 refactor: remove unused constructor of CDKGLogger (Konstantin Akimov)\nc82672af94034ce894cc507be53ba79f324e0ffd refactor: remove dependency of CDKGSession on PeerManager (Konstantin Akimov)\nfb78b0cc94c7ea5b637b79b4c24f7fd8dc9550c9 refactor: remove retBan flag from ReceiveMessage (Konstantin Akimov)\nd26d4ab0bc73df4cb1c4a2acd00c5aae73317347 refactor: remove dependency of dkgsessionmgr on dkgsession (Konstantin Akimov)\nd361b11e5b9aee282b5bde44e015d36487a662a9 refactor: moved including llmq/dkgsession.h from dkgsessionmgr.h to cpp file (Konstantin Akimov)\ne77aeb321b5e3c05c0462191f48084739e5c10d6 refactor: removed including quorums.h from chainlocks.h (Konstantin Akimov)\n6f7068ef425bd3dd2f7fa023cc7baff393d65c72 refactor: remove exceeding evodb.h from headers (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n We have 72 circular dependencies of dash specific code. This PR removes 2 of them, over dkgsession.\n\n ## What was done?\n Refactor dkgsession initialization, message processing, dropped unused arguments, re-distributed code between functions and modules... See each commit.\n Also optimized headers: excluded evo/evodb.h and llmq/quorums.h from the headers where they are not needed.\n\n ## How Has This Been Tested?\n Run `test/lint/lint-circular-dependencies.sh`\n Run unit/functional tests\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 74a5a9f98448ab59204296b4082c3598912b15ff\n PastaPastaPasta:\n utACK 74a5a9f98448ab59204296b4082c3598912b15ff\n\nTree-SHA512: f3adabe6a7bc6c4dcae6430be6857b31a0722d7f605d6651f3ff93c6fcb350a7312a9a0ecbda8ac131ffef6fbf2499700112de3990c7512ddb057bde7cc42665","shortMessageHtmlLink":"Merge #6282: refactor: drop some of circular dependencies over dkgses…"}},{"before":"6d615243e8f3e821e5a42669195c3e34def7be4a","after":"52928c548e2f72895aa177dd4b6ae98d7903d9f4","ref":"refs/heads/develop","pushedAt":"2024-09-24T18:53:53.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6281: chore: bump `MIN_PEER_PROTO_VERSION` to `70216`\n\n4602e097515bc949bb34dad8994cc3f979d4553e chore: bump `MIN_PEER_PROTO_VERSION` to `70216` (Kittywhiskers Van Gogh)\nee4115e73497e3753bd8d5c94c0e52e30b981bfe revert: Only sync mempool from v0.15+ (proto 70216+) nodes (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n Extracted from [dash#6272](https://github.com/dashpay/dash/pull/6272)\n\n ## Breaking Changes\n\n None expected.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 4602e097515bc949bb34dad8994cc3f979d4553e\n PastaPastaPasta:\n utACK 4602e097515bc949bb34dad8994cc3f979d4553e\n\nTree-SHA512: b3bc821c3e50d3fbd3d2d475cde4ccfca2ebedbaedf7209020c0007ca60a946a4e999775747b0b9615106b053ce0febbeaaf12106dfa810d5f3d2e98f8e73aaf","shortMessageHtmlLink":"Merge #6281: chore: bump MIN_PEER_PROTO_VERSION to 70216"}},{"before":"8f8cd61fd6c127d2f34929874afcc55d0a51ca93","after":"6d615243e8f3e821e5a42669195c3e34def7be4a","ref":"refs/heads/develop","pushedAt":"2024-09-24T13:59:39.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6264: backport: Merge bitcoin#23142, (partial) bitcoin-core/gui#409, 23333, 23755, (partial) 22981\n\n71689fe6dcfce9f7fe42e75767009f98fa5850e2 (partial) Merge bitcoin/bitcoin#22981: doc: Fix incorrect C++ named args (fanquake)\n2b71a9b030363d10f4d0e7b1f5453a054fbb5792 Merge bitcoin/bitcoin#23755: rpc: Quote user supplied strings in error messages (MarcoFalke)\n5a441b38defff1837e5872432734e16b55923d58 (partial) Merge bitcoin-core/gui#409: Fix window title of wallet loading window (Hennadii Stepanov)\n49c87e93a622cb127e91848a08b6574826f8b777 Merge bitcoin/bitcoin#23142: Return false on corrupt tx rather than asserting (W. J. van der Laan)\n\nPull request description:\n\n backports from bitcoin\n\nACKs for top commit:\n UdjinM6:\n utACK 71689fe6dcfce9f7fe42e75767009f98fa5850e2\n knst:\n utACK 71689fe6dcfce9f7fe42e75767009f98fa5850e2\n\nTree-SHA512: c68e2a1be5669f4fd8b02001ea81310b41fcac2cc5cc660e67b5140b334669c9a071a4bd5b33232580215607f323af5f87218a3465493675a633e112984296eb","shortMessageHtmlLink":"Merge #6264: backport: Merge bitcoin#23142, (partial) bitcoin-core/gu…"}},{"before":"60a7902b4306b88b0718afa7b56778e1895806a1","after":"8f8cd61fd6c127d2f34929874afcc55d0a51ca93","ref":"refs/heads/develop","pushedAt":"2024-09-24T13:56:16.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6274: backport: bitcoin#23723, 23547, 24153, 23591\n\n073d6d6b2a6eb2741fe461884574c671858e6cda Merge bitcoin/bitcoin#23723: test: Replace hashlib.new with named constructor (MarcoFalke)\n674dcf9a55e76cb036bf1f37db4ed7bf356d6d90 Merge bitcoin/bitcoin#23547: Bugfix: RPC/mining: Fail properly in estimatesmartfee if smart fee data is unavailable (MarcoFalke)\n546e5487558babaa2c1defbdb5adaf571599f3de Merge bitcoin/bitcoin#24153: test: remove unused sanitizer suppressions (fanquake)\n78b06a4dd2b8348c38ac719f34027a71296b2600 Merge bitcoin/bitcoin#23591: refactor: Use underlying type of isminetype for isminefilter (W. J. van der Laan)\n\nPull request description:\n\n backporting\n\nACKs for top commit:\n UdjinM6:\n utACK 073d6d6b2a6eb2741fe461884574c671858e6cda\n knst:\n utACK 073d6d6b2a6eb2741fe461884574c671858e6cda\n\nTree-SHA512: 5c5af5b795ec86f2b98cf9884e1275b8d3a5e7942f8b6632d74ecb799b1b7fe34071c052ac9af15abac14bad1b886ead5d0478f5e03fe0b461b7b40a7defef9e","shortMessageHtmlLink":"Merge #6274: backport: bitcoin#23723, 23547, 24153, 23591"}},{"before":"3b8f24431cfd0afee55878560a467fdeba7dc3aa","after":"60a7902b4306b88b0718afa7b56778e1895806a1","ref":"refs/heads/develop","pushedAt":"2024-09-24T13:51:36.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6272: trivial: remove some legacy code, make global a `unique_ptr`, simplify `get_next_work` test, make UBSan CI halt on error (misc. changes)\n\n4e621037c5553e24decbebefd3a68305b7063b72 test: move `EXPECTED_STDERR_NO_GOV`{`_PRUNE`} and use it more (Kittywhiskers Van Gogh)\n77ce6af5c1f9518a22247be622389c72a195ec32 chore: remove ancient setting migration logic (Kittywhiskers Van Gogh)\n061aa05cf0961ca17f235e8bf4cb845db0356b61 chore: remove old llmq db migration code (Kittywhiskers Van Gogh)\n438cb85eceaecc27c8913e2aa769bd76c5a74666 ci: set UBSan to halt on error and provide more information (Kittywhiskers Van Gogh)\n3a1743fc7fe66c82a07f5c8643b68e1aa520a9f9 trivial: avoid unneeded copy when iterating through `mapDenomCount` (Kittywhiskers Van Gogh)\ncba650953af4a5ac12c495475457f1d30181b58e test: simplify `pow_test`'s `get_next_work` block index construction (Kittywhiskers Van Gogh)\ndacf8592189883705538cb1764f21e6e3895209a refactor: make `pdsNotificationInterface` a `unique_ptr`, rename (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n Collection of miscellaneous changes collected from work on earlier pull requests that don't fit into pull requests in the immediate future but are nonetheless useful.\n\n ## Checklist\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n re-utACK 4e621037c5553e24decbebefd3a68305b7063b72\n UdjinM6:\n utACK 4e621037c5553e24decbebefd3a68305b7063b72\n\nTree-SHA512: 5af4e5afdc34840905ffbf375f53cb12b682053cc135ff190dd02d245da9903a7f3e6af6fb1f1727546bf5034cbe42243477342f775e05d15bcfc5d5957616e9","shortMessageHtmlLink":"Merge #6272: trivial: remove some legacy code, make global a `unique_…"}},{"before":"a9a2d4adbebf34b6d265834d4c2ff0305b58ab2b","after":"3b8f24431cfd0afee55878560a467fdeba7dc3aa","ref":"refs/heads/develop","pushedAt":"2024-09-24T13:47:01.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6280: backport: merge bitcoin#26519, #25880, #26982, #26584, #27577, #28419, #28196, #28433, #28489, #28525 (BIP324 backports)\n\n63b13aa51915a647ce702ed229e912762aad7ffc merge bitcoin#28525: Drop v2 garbage authentication packet (Kittywhiskers Van Gogh)\n662394cd49e988699bc6e0fb3005fd435c272505 merge bitcoin#28489: fix incorrect assumption in v2transport_test (Kittywhiskers Van Gogh)\n98782c62df7f0354368583b4a87dbed6c7f30ead merge bitcoin#28433: Follow-up to BIP324 connection support (Kittywhiskers Van Gogh)\nf9825168fbd61a1ec49610623d88338e47667863 merge bitcoin#28196: BIP324 connection support (Kittywhiskers Van Gogh)\n3087275039ffdcf4421a65ea12ee9fdc9cf49c6d merge bitcoin#28419: introduce and use `ConsumePrivateKey` helper (Kittywhiskers Van Gogh)\ndccd395a4eb70463750f17eede046dc968ce39ce merge bitcoin#27577: give seednodes time before falling back to fixed seeds (Kittywhiskers Van Gogh)\neb4f01f931a507534e815a4f3abb998e93d35fd2 merge bitcoin#26584: include local (\"unreachable\") peers in -netinfo table (Kittywhiskers Van Gogh)\n10dc874136bc626b45e7762635ecdcc79203c258 merge bitcoin#26982: bitcoin#25880 fixups (Kittywhiskers Van Gogh)\na36f8f2a1a85c20afde0f334d07306ffb171e5d3 merge bitcoin#25880: Make stalling timeout adaptive during IBD (Kittywhiskers Van Gogh)\n1d77f3ff550f2b27019a1e436ea617f2ea909645 merge bitcoin#26519: Add getpeerinfo test for missing version message (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * When backporting [bitcoin#25880](https://github.com/bitcoin/bitcoin/pull/25880), changes needed to be made to `p2p_ibd_stalling.py` to help it pass.\n * DIP3 activation had to be delayed to a block beyond the range of the test. This is to prevent block rejection arising from a missing DIP3-compliant coinbase (done with `-dip3params=2000:2000`)\n * Mock time was disabled to ensure nodes in the test do not resort to direct fetching (with mock time enabled, nodes would be considered close apart in time, which would prevent the primary node from fetching in parallel, which is behavior this test relies on) (done with `self.disable_mocktime = True`)\n * The nodes connected do not report compressed headers support (the test relies on sending `headers` messages and reworking it to use compressed headers has little benefit) (done with `services = NODE_NETWORK | NODE_BLOOM`)\n\n * When backporting [bitcoin#28196](https://github.com/bitcoin/bitcoin/pull/28196), in the `v2transport_test` unit test, references to `4000000` were substituted with `MAX_PROTOCOL_MESSAGE_LENGTH` as Dash messages have a protocol limit of 3MiB ([source](https://github.com/dashpay/dash/blob/d754799580d2914a0dd6388c90100d14feec0428/src/net.h#L79-L80)) while Bitcoin messages have a protocol limit of 4MB ([source](https://github.com/bitcoin/bitcoin/blob/225718eda89d65a7041c33e1994d3bf7bd71bbdd/src/net.h#L62-L63)).\n * Additionally note that short message IDs as defined in the BIP324 spec ([source](https://github.com/bitcoin/bips/blob/22660ad3078ee9bd106e64d44662a59a1967c4bd/bip-0324.mediawiki#v2-bitcoin-p2p-message-structure)) have not been changed to include Dash-specific messages, meaning, Dash-specific messages will always take 13 bytes.\n * As `FEEFILTER` is not supported by Dash, it has been replaced with a blank string in the short IDs table. It was not removed as doing so would disturb the table's arrangement as specified in spec and require readjustment of tests to account for the change in layout.\n\n ## Breaking Changes\n\n None expected.\n\n ## Checklist\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 63b13aa51915a647ce702ed229e912762aad7ffc\n knst:\n utACK 63b13aa51915a647ce702ed229e912762aad7ffc\n\nTree-SHA512: c41d2c6b1f145be513e285c8f91d00ac31fff4e4d24f611a1fdab24c8740f453b0bb28912021cdf8be4f5ce93dcff8579864727ee14b8e45894b56df524ab48d","shortMessageHtmlLink":"Merge #6280: backport: merge bitcoin#26519, bitcoin#25880, bitcoin#26982"}},{"before":"312134e39e00c62c02d34afde018a907af992c75","after":"a9a2d4adbebf34b6d265834d4c2ff0305b58ab2b","ref":"refs/heads/develop","pushedAt":"2024-09-23T17:42:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6263: backport: Merge bitcoin/bitcoin#23064\n\n3c51f3ab1e3c37ca93df73b7c38ca3c555b04e86 Merge bitcoin/bitcoin#23064: fuzz: Fix memory leak in system fuzz target (MarcoFalke)\n\nPull request description:\n\n Backports\n\nACKs for top commit:\n UdjinM6:\n utACK 3c51f3ab1e3c37ca93df73b7c38ca3c555b04e86\n knst:\n utACK 3c51f3ab1e3c37ca93df73b7c38ca3c555b04e86\n\nTree-SHA512: 1dc54750d0d897f272e65a25f25cd83ed21b9df02313a933286d0651c4e73c0c1c84aba643e81d33097746bde38a028c1c524f973c0f973c1555ede31f176cba","shortMessageHtmlLink":"Merge #6263: backport: Merge bitcoin#23064"}},{"before":"2b92b3e29e2ed9f0dbf7fe254206409f4eda0b49","after":"312134e39e00c62c02d34afde018a907af992c75","ref":"refs/heads/develop","pushedAt":"2024-09-23T16:50:57.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6239: feat: increase the number of block headers able to be downloaded at once to 8000 in protocol version `70235`\n\n48c7f98b1a4802e9acb9697ccebbeaf4ec90eb10 doc: drop trailing whitespace (pasta)\n697743d77b344f7404519323d35ba2fa59b08109 test: add missing import (UdjinM6)\ncfe99fd289cfd43f8ee4788bb14ede5724d6e5a5 docs: add release notes for 6239 (pasta)\na6bbaacfaa50a88f4f9d5a58097b6f5fe7c9ee55 fix: GetHeadersLimit is used for getheaders(2) and headers(2), refactor it to accept `compressed` instead of `msg_type` (UdjinM6)\nb224f3f6cac565663c3d7ce47e0bea5deeeef7dd bump p2p_version in tests (PastaPastaPasta)\nb423f42aae4598c34e71b573d2b5e613aff2307e refactor: sort imports (UdjinM6)\nf6c68ba71b62bcadf56f9e2fa5fc6d054dd84be0 refactor: simplify _compute_requested_block_headers (UdjinM6)\n07876b2c4a539b55bac476ee8a2241cff3c2a3aa use `MAX_HEADERS_UNCOMPRESSED_RESULT` not `MAX_HEADERS_UNCOMPRESSED_RESULTS` ; use `MAX_HEADERS_UNCOMPRESSED_RESULT` in RPC to avoid breaking changes (pasta)\nb137280df47779b0338d828a76bd23b005d227a2 change to _COMPRESSED or _UNCOMPRESSED (pasta)\n303bc7af99b21d8596171be9747153eb759c8793 fix: increase it for headers2 only (UdjinM6)\ne23410ffddb4325088708493ab9fd85716030d05 trivial: rename `MAX_HEADERS_RESULTS_NEW` to `MAX_HEADERS_RESULTS` (Kittywhiskers Van Gogh)\nbcf032069141529be0b08eadda6cd38f73e23422 trivial: move the headers limit determination to `GetHeadersLimit()` (Kittywhiskers Van Gogh)\n993c7c0f90b41d723a8efd5ef5754a282503265b feat: increase the number of block headers able to be downloaded at once to 8000 in protocol version `70234` (pasta)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n We did some testing quite a while ago that found that sending 8000 headers at a time could speed stuff up. But we wanted to wait until compressed headers were implemented. Well, they've been implemented!\n\n ## What was done?\n Bump 2000 -> 8000 triggered by protocol version\n\n ## How Has This Been Tested?\n Hasn't, we should setup a few nodes running this and sync them from each other\n\n ## Breaking Changes\n New protocol version, not breaking but should add notes? I should probably add release notes\n\n ## Checklist:\n _Go over all the following points, and put an `x` in all the boxes that apply._\n - [ ] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n light ACK 48c7f98b1a4802e9acb9697ccebbeaf4ec90eb10\n knst:\n utACK 48c7f98b1a4802e9acb9697ccebbeaf4ec90eb10\n\nTree-SHA512: 54c68b9496131ab7f32504d44398d776a151df809d0120d093bbabb18904a783bd9b58796820209f5d75552df5476e30eaa09d68f7c5057882f94b5766a64f4c","shortMessageHtmlLink":"Merge #6239: feat: increase the number of block headers able to be do…"}},{"before":"13e3dd9dfa310a214c5142a7eafc86bffbb6089a","after":"2b92b3e29e2ed9f0dbf7fe254206409f4eda0b49","ref":"refs/heads/develop","pushedAt":"2024-09-23T16:17:55.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6261: fix: assert in signing_shares for quorums with 3 members but 2 nodes only\n\nf44edde8fea9d993c76b22033dcc458602fb3f04 tests: use only 2 MN and 2 Evo nodes in feature_asset_locks.py to be sure that is enough (Konstantin Akimov)\n8286bdf611949e248dd5cc3e090634577512c070 fix: assert in signing_shares - amount of members can match with amount of attempts (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Currently we have several quorums which have size 3 with threshold 2 nodes: `llmq_test_instantsend`, `llmq_test_platform`, `llmq_test` and they are used on RegTest.\n\n For extreme case when only 2 nodes exist the assert happens:\n\n ```\n AssertionError: Unexpected stderr dashd: llmq/signing_shares.cpp:812: static CDeterministicMNCPtr llmq::CSigSharesManager::SelectMemberForRecovery(const llmq::CQuorumCPtr&, const uint256&, size_t): Assertion `size_t(attempt) < quorum->members.size()' failed.\n Posix Signal: Aborted\n 0#: (0x5BF40CE70DA2) stl_vector.h:115 - std::_Vector_base >::_Vector_impl_data::_M_copy_data(std::_Vector_base >::_Vector_impl_data const&)\n 1#: (0x5BF40CE70DA2) stl_vector.h:127 - std::_Vector_base >::_Vector_impl_data::_M_swap_data(std::_Vector_base >::_Vector_impl_data&)\n 2#: (0x5BF40CE70DA2) stl_vector.h:1962 - std::vector >::_M_move_assign(std::vector >&&, std::integral_constant)\n 3#: (0x5BF40CE70DA2) stl_vector.h:771 - std::vector >::operator=(std::vector >&&)\n 4#: (0x5BF40CE70DA2) stacktraces.cpp:777 - HandlePosixSignal\n 5#: (0x7664C9245320) libc_sigaction.c - ???\n 6#: (0x7664C929EB1C) pthread_kill.c:44 - __pthread_kill_implementation\n 7#: (0x7664C929EB1C) pthread_kill.c:78 - __pthread_kill_internal\n 8#: (0x7664C929EB1C) pthread_kill.c:89 - __GI___pthread_kill\n 9#: (0x7664C924526E) raise.c:27 - __GI_raise\n 10#: (0x7664C92288FF) abort.c:81 - __GI_abort\n 11#: (0x7664C922881B) loadmsgcat.c:1177 - _nl_load_domain\n 12#: (0x7664C923B507) - ???\n 13#: (0x5BF40C6E88C8) signing_shares.cpp:823 - llmq::CSigSharesManager::SelectMemberForRecovery(std::shared_ptr const&, uint256 const&, unsigned long)\n 14#: (0x5BF40C94A285) quorums.cpp:737 - operator()\n 15#: (0x5BF40C94A514) std_function.h:292 - _M_invoke\n 16#: (0x5BF40CE082C6) util.cpp:510 - RPCHelpMan::HandleRequest(JSONRPCRequest const&) const\n 17#: (0x5BF40C89824A) univalue.h:17 - UniValue::operator=(UniValue&&)\n 18#: (0x5BF40C89824A) server.h:108 - CRPCCommand::CRPCCommand(std::__cxx11::basic_string, std::allocator >, RPCHelpMan (*)())::{lambda(JSONRPCRequest const&, UniValue&, bool)#1}::operator()(JSONRPCRequest const&, UniValue&, bool) const\n 19#: (0x5BF40C9976F4) std_function.h:591 - std::function::operator()(JSONRPCRequest const&, UniValue&, bool) const\n 20#: (0x5BF40C9976F4) server.cpp:622 - ExecuteCommand\n 21#: (0x5BF40C99879F) server.cpp:511 - ExecuteCommands\n 22#: (0x5BF40C99879F) server.cpp:543 - CRPCTable::execute(JSONRPCRequest const&) const\n 23#: (0x5BF40CB75F24) httprpc.cpp:247 - HTTPReq_JSONRPC\n ```\n\n Discovered during implementation of https://github.com/dashpay/dash-issues/issues/77\n\n ## What was done?\n Changed condition in assert, implemented special case of using Nth element from array size N for `SelectMemberForRecovery`, added test for this case.\n\n ## How Has This Been Tested?\n Improved functional test `feature_asset_locks.py` to test this corner case for quorum `llmq_test_instantsend` and `llmq_test_platform`\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK f44edde8fea9d993c76b22033dcc458602fb3f04\n PastaPastaPasta:\n utACK f44edde8fea9d993c76b22033dcc458602fb3f04\n\nTree-SHA512: 5e8035960100778820bbbb242a8a354a27bce00c169bbebc4f3867737301dbdd3cc5993a8d806d55bf6eb467bfe1f36443087a271acc227ba7bb301c4f75bb7a","shortMessageHtmlLink":"Merge #6261: fix: assert in signing_shares for quorums with 3 members…"}},{"before":"89a7c60aecff893e9e422ac006621eef89ae4e62","after":"13e3dd9dfa310a214c5142a7eafc86bffbb6089a","ref":"refs/heads/develop","pushedAt":"2024-09-23T16:16:04.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #5481: feat: Split quorum contrib data out of evodb\n\nad35c1ab2f3046b95c5cd85fa1c6ba086cb993e3 apply suggestions (UdjinM6)\n600dcf3dda2964ac01a0bad65e87abeae87aa291 refactor: make clang-format happy (UdjinM6)\nda9b8e038b4e618decd418107d22c2ef1b88e832 feat: Split quorum contribution db out of evodb (UdjinM6)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Quorum data is not stored on-chain, it's a temporary data produced during dkg and should not be a part of evodb.\n\n ## What was done?\n Use new db in `llmq/` to store quorum data, migrate old data to it.\n\n ## How Has This Been Tested?\n Run tests, run a node on testnet\n\n ## Breaking Changes\n n/a\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n knst:\n utACK ad35c1ab2f3046b95c5cd85fa1c6ba086cb993e3\n PastaPastaPasta:\n utACK ad35c1ab2f3046b95c5cd85fa1c6ba086cb993e3\n\nTree-SHA512: b394a53815897f02ec28776c948a32c258ad7f0d9b78fbfd509146a92c8af53e7577d503bc62ae53c40f88aab2c30160fec09f45f0d3447ba64c05c0887676eb","shortMessageHtmlLink":"Merge #5481: feat: Split quorum contrib data out of evodb"}},{"before":"d754799580d2914a0dd6388c90100d14feec0428","after":"89a7c60aecff893e9e422ac006621eef89ae4e62","ref":"refs/heads/develop","pushedAt":"2024-09-18T16:27:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6277: chore: add builder key for kittywhiskers\n\n315fcea83493266449a96739c7f028cdff00cc75 chore: add builder key for kittywhiskers (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n Key ID `30CD 0C06 5E5C 4AAD`. Same key registered with Keybase ([source](https://keybase.io/kittywhiskers/pgp_keys.asc?fingerprint=969187a8e74fe40a8a48067430cd0c065e5c4aad)) and used to sign commits on GitHub. PGP key named after Keybase username.\n\nACKs for top commit:\n UdjinM6:\n utACK 315fcea83493266449a96739c7f028cdff00cc75\n knst:\n ACK 315fcea83493266449a96739c7f028cdff00cc75\n PastaPastaPasta:\n utACK 315fcea83493266449a96739c7f028cdff00cc75\n\nTree-SHA512: f566c514831cfaf0a8bf95ebfb8aa5629474bdf0b88fd8948d4c1d3f1340ccdd3a9c67c817bd08d2f4d2e477b1599bf4fd148ad50fe68357d24feba651d832f7","shortMessageHtmlLink":"Merge #6277: chore: add builder key for kittywhiskers"}},{"before":"05740e82643b948ade650d329f2af15cb134b208","after":"d754799580d2914a0dd6388c90100d14feec0428","ref":"refs/heads/develop","pushedAt":"2024-09-17T02:44:30.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6270: fix: remove mn_rr fork usage from functional test of EHF\n\n056d869571d25030635ead895d40dc340b70a3ae refactor: use testdummy in feature_mnehf functional test, removed useless checks (Konstantin Akimov)\n0351469bb579bc9f10c7eccd483431c077ec992f refactor: removed duplicated meaningless condition from Check mnhftx (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Using mn_rr in feature_mnehf.py is a blocker for burying mn_rr fork.\n\n ## What was done?\n Removed useless conditions, uses testdummy fork instead mn_rr in ehf functional test.\n\n ## How Has This Been Tested?\n Run it `test/functional/feature_mnehf.py`\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 056d869571d25030635ead895d40dc340b70a3ae\n PastaPastaPasta:\n utACK 056d869571d25030635ead895d40dc340b70a3ae\n\nTree-SHA512: aa016dc21fee3afdb5a4172e757cdd0b92867c23eb5241287f641d3c97d363ab1c46eba06423481ecc7ba05f6c0010b65eadfe77d4a1fd6074706cc6f3a71309","shortMessageHtmlLink":"Merge #6270: fix: remove mn_rr fork usage from functional test of EHF"}},{"before":"ca4b9eaad152e51703a75bb27684ad3aa4661856","after":"05740e82643b948ade650d329f2af15cb134b208","ref":"refs/heads/develop","pushedAt":"2024-09-17T02:25:59.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6271: feat: simplify and speedup feature_governance.py test by generating less blocks\n\n42dffe854103aec3f539ae112768bac40ea0ec5a chore: improve logging of functional tests feature_governance.py (Konstantin Akimov)\n922b796800140d9484a0cfa81c5185e803ffff6d feat: simplify and speedup feature_governance.py test by generating less blocks (Konstantin Akimov)\n\nPull request description:\n\n ## Issue being fixed or feature implemented\n Too many blocks are generated in a functional tests `feature_governance.py`\n\n ## What was done?\n 1. Activate v20 faster for `feature_governance.py`, drop generation of useless blocks, simplify code.\n\n 2. Added extra logging for this test by converting comments to logs.\n\n ## How Has This Been Tested?\n Run `test/functional/feature_governance.py`\n Locally improvement of performance is less than 5 seconds.\n `tsan` jobs on CI:\n ```\n 204/264 - feature_governance.py --legacy-wallet passed, Duration: 243 s\n 208/264 - feature_governance.py --descriptors passed, Duration: 270 s\n ```\n ↑ [old version](https://gitlab.com/dashpay/dash/-/jobs/7805625816) vs [new version](https://gitlab.com/dashpay/dash/-/jobs/7819897536) ↓:\n ```\n 193/264 - feature_governance.py --legacy-wallet passed, Duration: 220 s\n 199/264 - feature_governance.py --descriptors passed, Duration: 240 s\n ```\n\n Most of the time is spent in `feature_governance.py` on stage \"let all fulfilled requests expire for re-sync to work correctly\" so that's a very minor optimization.\n\n ## Breaking Changes\n N/A\n\n ## Checklist:\n - [x] I have performed a self-review of my own code\n - [ ] I have commented my code, particularly in hard-to-understand areas\n - [ ] I have added or updated relevant unit/integration/functional/e2e tests\n - [ ] I have made corresponding changes to the documentation\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n UdjinM6:\n utACK 42dffe854103aec3f539ae112768bac40ea0ec5a\n PastaPastaPasta:\n utACK 42dffe854103aec3f539ae112768bac40ea0ec5a\n\nTree-SHA512: 9257301043efca8b3775fff64e598b153e00bc48779212e6237ab63f06a043a66764d72e38d9e6071b82477e55884b9bce410f4d3fabeb13da631505113e86bc","shortMessageHtmlLink":"Merge #6271: feat: simplify and speedup feature_governance.py test by…"}},{"before":"d290df38edf407f54df67f239b485a72979a4bea","after":"ca4b9eaad152e51703a75bb27684ad3aa4661856","ref":"refs/heads/develop","pushedAt":"2024-09-16T17:01:24.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6255: backport: merge bitcoin#24531, #25500, #25814, #25962, #26888, #27264, #27257, #27324, #27374, #27467, #27411, partial bitcoin#25472 (networking backports: part 8)\n\n8320e0ca8ea3adda8dd672f716bf6214d034e5de merge bitcoin#27411: Restrict self-advertisements with privacy networks to avoid fingerprinting (Kittywhiskers Van Gogh)\n1376289b11c624a2b648ae1b117d398303e10bfa merge bitcoin#27467: skip netgroup diversity follow-up (Kittywhiskers Van Gogh)\na52b3a3bf0891bed8822453e45d310160cf6dd8f merge bitcoin#27374: skip netgroup diversity of new connections for tor/i2p/cjdns (Kittywhiskers Van Gogh)\nab11e0f998cf41f62e4f3601eb21f134c6f4994a merge bitcoin#27324: bitcoin#27257 follow-ups (Kittywhiskers Van Gogh)\n9023dd25af698ee163bc5438f84588f09221f61c merge bitcoin#27257: End friendship of CNode, CConnman and ConnmanTestMsg (Kittywhiskers Van Gogh)\n3465df2689ea7b9fbdb67fc41afc90f705d20dde merge bitcoin#27264: Improve diversification of new connections (Kittywhiskers Van Gogh)\nd3f5b3881b80b3d590bb20ec60199b89dde3f7dd merge bitcoin#26888: simplify the call to vProcessMsg.splice() (Kittywhiskers Van Gogh)\nd9e56f3e780f597de1f7bf4ec88fce345267253b merge bitcoin#25962: Add CNodeOptions and increase constness (Kittywhiskers Van Gogh)\n79e67fd96a3ba1680fd24ac0110faa8ea1464c84 merge bitcoin#25814: simplify GetLocalAddress() (Kittywhiskers Van Gogh)\n6d4945418a472d9e25721baf3f767ca7f35c0781 partial bitcoin#25472: Increase MS Visual Studio minimum version (Kittywhiskers Van Gogh)\n54bb3a438f6fc843863ac8dbf476bd22606440db merge bitcoin#25500: Move inbound eviction logic to its own translation unit (Kittywhiskers Van Gogh)\nb50febc0f0d0bfcd5cf5a92ef9a79302b71acb6d merge bitcoin#24531: Use designated initializers (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * Dependent on https://github.com/dashpay/dash/pull/6254\n * When backporting [bitcoin#27411](https://github.com/bitcoin/bitcoin/pull/27411), the `CNetAddr*` variant of `GetLocal()` was not removed (upstream it was replaced by the `CNode&` variant with additional checks that rely on fields in `CNode`) as `CActiveMasternodeManager` relies on `GetLocal()` to detect a valid external address.\n * While it can also rely on other nodes to determine that, removing code that tests against a well-known public address would increase the number of reported failures esp. if the checks are run _before_ the node has a chance to connect to any peers.\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 8320e0ca8ea3adda8dd672f716bf6214d034e5de\n PastaPastaPasta:\n utACK 8320e0ca8ea3adda8dd672f716bf6214d034e5de\n\nTree-SHA512: 1d02bc33c8d62c392960d4dd044edf3de08515a5e8c8794d95cd95e9654da91b20e7290436cf9c79b0ea8dbd42b27dcc61c8eb17e573902574d7b281b8874584","shortMessageHtmlLink":"Merge #6255: backport: merge bitcoin#24531, bitcoin#25500, bitcoin#25814"}},{"before":"17110f50b3adb1b8a51348259e752a760ab3ee0a","after":"d290df38edf407f54df67f239b485a72979a4bea","ref":"refs/heads/develop","pushedAt":"2024-09-15T03:58:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6273: backport: merge bitcoin#27015 (resolve flaky addrman unit test)\n\n925870d7d0ea97fba101f9ba67a72d73d46fbbda merge bitcoin#27015: bitcoin#26847 fixups (AddrMan totals) (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n As part of [dash#6254](https://github.com/dashpay/dash/pull/6254), [bitcoin#26847](https://github.com/bitcoin/bitcoin/pull/26847) was backported and since then, it was observed that unit tests were flakier than expected ([build](https://gitlab.com/dashpay/dash/-/jobs/7811041841), [build](https://gitlab.com/dashpay/dash/-/jobs/7802460298)).\n\n The flakiness was caused by behavior introduced by the aforementioned backport, this was resolved upstream with [bitcoin#27015](https://github.com/bitcoin/bitcoin/pull/27015), which this pull request contains.\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK 925870d7d0ea97fba101f9ba67a72d73d46fbbda\n knst:\n ACK 925870d7d0ea97fba101f9ba67a72d73d46fbbda\n\nTree-SHA512: 20fc8fb1b162803a71ec4087685460f52ed56c3c86d46ecac4cc0ef59c95b4b6206f0c53bef256242a4a5babb76e3564cfba56a84cbe844e187035de2308b818","shortMessageHtmlLink":"Merge #6273: backport: merge bitcoin#27015 (resolve flaky addrman uni…"}},{"before":"96685be6857e5789e621b1ffe0b71c47d2c2ace7","after":"17110f50b3adb1b8a51348259e752a760ab3ee0a","ref":"refs/heads/develop","pushedAt":"2024-09-12T14:41:43.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #6254: backport: merge bitcoin#25678, #26040, #26847, #25619, #27214, #26261, #27745, #27529, #28341, partial bitcoin#25331 (addrman backports: part 4)\n\ne544d3c741b79ab72b58f255e352e49a096a746d fmt: apply `clang-format-diff.py` suggestions, satisfy linter (Kittywhiskers Van Gogh)\n7da74ffcd56305555aecc4a3d6b2be9e3c53cedf merge bitcoin#28341: Use HashWriter over legacy CHashWriter (Kittywhiskers Van Gogh)\nc798b496cd7613900d46894054c0f2550f78bd4d merge bitcoin#27529: fix `feature_addrman.py` on big-endian systems (Kittywhiskers Van Gogh)\n7d149c97be976f4c0a429b6107aa40856993750e merge bitcoin#27745: select addresses by network follow-up (Kittywhiskers Van Gogh)\n1d829943835326c34ba618266a78f0488b20fd57 merge bitcoin#26261: cleanup `LookupIntern`, `Lookup` and `LookupHost` (Kittywhiskers Van Gogh)\n231ff82c2eb89bfc375e6076272a9ffa52c3bb26 merge bitcoin#27214: Enable selecting addresses by network (Kittywhiskers Van Gogh)\ne82559516ca25e932c30aa252154c6df6e01cf10 merge bitcoin#25619: avoid overriding non-virtual ToString() in CService and use better naming (Kittywhiskers Van Gogh)\n2e9b48a910779ad21d15eda08c8974699af90d53 merge bitcoin#26847: track AddrMan totals by network and table, improve precision of adding fixed seeds (Kittywhiskers Van Gogh)\n79a550ec15f5d5d89105f2d1747419025d67d18e merge bitcoin#26040: comment \"add only reachable addresses to addrman\" (Kittywhiskers Van Gogh)\n1adb635ec641dc1b20f79726c2a20a4e75558b60 merge bitcoin#25678: skip querying dns seeds if -onlynet disables IPv4 and IPv6 (Kittywhiskers Van Gogh)\n2d99be0aea06e81c0ee84dacf213f70663d3966f partial bitcoin#25331: Add HashWriter without ser-type and ser-version (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n * Dependent on https://github.com/dashpay/dash/pull/6243\n\n * Dependent on https://github.com/dashpay/dash/pull/5167\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_\n\nACKs for top commit:\n UdjinM6:\n utACK e544d3c741b79ab72b58f255e352e49a096a746d\n\nTree-SHA512: 63f014142c39c47bda3ac85dc6afeee8f2bfec71f033631bca16d41bb0785f4b090b3c860ddc3b3cf6c4a23558d3d102144fc83b065130c3f9ab91d0de8e4457","shortMessageHtmlLink":"Merge #6254: backport: merge bitcoin#25678, bitcoin#26040, bitcoin#26847"}},{"before":"f2645df7d366ae8e067d5340358b835196dd2dad","after":"96685be6857e5789e621b1ffe0b71c47d2c2ace7","ref":"refs/heads/develop","pushedAt":"2024-09-11T16:18:05.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"PastaPastaPasta","name":null,"path":"/PastaPastaPasta","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6443210?s=80&v=4"},"commit":{"message":"Merge #5167: refactor(stats): modernize `statsd::StatsdClient`, make global `unique_ptr`\n\ncc998abec16bfb1f2d55d92e4c0e6a495576c775 fmt: apply `clang-format-diff.py` suggestions (Kittywhiskers Van Gogh)\n0401c581eb3f4ea2303c9390d81ac081980af953 stats: `const`-ify variables and arguments (Kittywhiskers Van Gogh)\n9f967237742d3d19ece2fdbc294808f83d47073b stats: stop using error codes, switch over to `bool` (Kittywhiskers Van Gogh)\n1a81979c1e8cf47df28d785689b4049e1504d0d1 stats: initialize socket after we have a valid socket address (Kittywhiskers Van Gogh)\ndbbfc8d766903569ee99759c1b331e55a4dbd306 stats: use `Socks` wrapper, use `CService` to generate our `sockaddr` (Kittywhiskers Van Gogh)\n2def905044702dc9c9149b07d8a0bae17badd0d5 stats: move init logic into constructor (Kittywhiskers Van Gogh)\n4bc727cd6c235415f63a076f0377043959f10b60 stats: clean up randomization code, move `FastRandomContext` inward (Kittywhiskers Van Gogh)\n840241eefd7c65abd39a73fc1831976ab0694ecb stats: cleanup error logging, improve code sanity (Kittywhiskers Van Gogh)\n85890ddb1370fc625101e37f7bfb225c24f973ff docs: add copyright notice to source file, update notice in header (Kittywhiskers Van Gogh)\na9d1b1494d4f430531c8f4345d63576d454a1e2e stats: move `_StatsdClientData` variables into `StatsdClient` (Kittywhiskers Van Gogh)\n30c30c1397d23fbe6b6e7da57c2b52e97d1899c9 stats: fetch all arguments needed when constructing `g_stats_client` (Kittywhiskers Van Gogh)\n5133d88415bdff2e32a921d3ee10f5e81920d91b stats: s/statsClient/g_stats_client/g (Kittywhiskers Van Gogh)\nf81951dd00f11d860ef9c249680d27506b19a706 stats: make `statsClient` a `std::unique_ptr`, denote as global variable (Kittywhiskers Van Gogh)\n\nPull request description:\n\n ## Additional Information\n\n Support for transmitting stats to a Statsd server has been courtesy of Statoshi ([repo](https://github.com/jlopp/statoshi)), implemented Dec, 2020 by [dash#2515](https://github.com/dashpay/dash/pull/2515) but since then, it hasn't gotten much attention aside from benefiting from codebase-wide changes and the occasional compiler appeasement. This pull request aims to give our statistics code some TLC.\n\n Changes include:\n\n * Limiting initialization to solely during construction and moving the responsibility of fetching arguments outside of `statsd::StatsdClient`.\n * Using the RAII `Socks` wrapper as early as possible (we still need to construct a raw socket ourselves but this is done in the initializer and control is moved to the wrapper and everywhere else, the wrapper is used)\n * Utilizing existing networking code to generate the socket address\n * This lets us trivially allow IPv6 connections as the responsibility to construct it safely is moved to `CService`.\n * Using `std::string` and our string manipulation capabilities (replacing `snprintf` with `strprintf`), replacing platform-specific types (replacing `short` with `uint16_t`).\n\n ## Breaking Changes\n\n None observed.\n\n ## Checklist:\n\n - [x] I have performed a self-review of my own code\n - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**\n - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**\n - [x] I have made corresponding changes to the documentation **(note: N/A)**\n - [x] I have assigned this pull request to a milestone\n\nACKs for top commit:\n PastaPastaPasta:\n utACK [cc998ab](https://github.com/dashpay/dash/pull/5167/commits/cc998abec16bfb1f2d55d92e4c0e6a495576c775)\n UdjinM6:\n utACK cc998abec16bfb1f2d55d92e4c0e6a495576c775\n\nTree-SHA512: 433c92160d6ac7ebb8582ada3cbb65ead7913618266b773619a528c90dfe0e286aafa46dc3b0bca62f246938e5948a732080e2cddba942d3627f007ca6efcc1f","shortMessageHtmlLink":"Merge #5167: refactor(stats): modernize statsd::StatsdClient, make …"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yN1QxNzo0OTo0NS4wMDAwMDBazwAAAATC4d6l","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMVQxNjoxODowNS4wMDAwMDBazwAAAASzbSkF"}},"title":"Activity · dashpay/dash"}