Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from transitions to animations #13

Open
darsain opened this issue Mar 6, 2015 · 3 comments
Open

Move from transitions to animations #13

darsain opened this issue Mar 6, 2015 · 3 comments
Milestone

Comments

@darsain
Copy link
Owner

darsain commented Mar 6, 2015

CSS animations have 90%+ support right now, and they would make life quite easier, and API cleaner.

The cons are none, as animation support is the same as transition support. I don't even know why I went with transitions. I guess it seemed simpler from styling perspective, but it's definitely not the right tool for this job.

@darsain darsain added this to the 1.0 milestone Mar 6, 2015
@kmiyashiro
Copy link

I'm curious as to why you feel like animations are better than transitions in this case?

@darsain
Copy link
Owner Author

darsain commented Aug 8, 2015

Not really performance. I had a styles & script structure that would make animations implementation simpler than transitions.

But I think I'm gonna re-evaluate this issue. I've since realized that animations have one very bad side effect: if you change state of the element mid transition (like hiding an element that is just animating in and vice versa), transitions are able to just pick up from the current position and animate back seamlessly. Animations start from the beginning of their defined keyframes, leading to something that would be perceived as stuttering, which is not acceptable.

Unless there is a way how to do that via animation direction or some other CSS properties. Dunno, will have to research that.

I'm gonna leave this issue open as a reminder that I still need to rework transitions. I don't like how they are implemented right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@kmiyashiro @darsain and others