Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutli-app-run should monitor processes and close on exit #1354

Open
paulyuk opened this issue Oct 11, 2023 · 3 comments
Open

Mutli-app-run should monitor processes and close on exit #1354

paulyuk opened this issue Oct 11, 2023 · 3 comments
Labels
area/cli area/test/e2e kind/feature New feature or request kind/proposal A new proposal to be considered P1 triaged/resolved The issue has been triaged
Milestone

Comments

@paulyuk
Copy link

paulyuk commented Oct 11, 2023

Describe the proposal

Today if you do the multi app run, e.g. on Workflow quickstart, it has some unexpected behaviors where the dapr console apps all complete and exit, but dapr run keeps running. It looks like dapr run never will exit which is unexpected, and you have to force exit with CTL C etc.

The mainline proposal is we should add process monitoring and by default exit dapr run when *all dapr app processes have exited.

There is also a case where some but not all dapr processes exit. My suggestion and leaning is we do not exit dapr in this case, because there might be valid reasons for a job to exit, but keep the services alive. We could however add a user config with a short circuit where if any processes exit, the whole dapr run exits.

Release Note

Multi-app-run now monitors processes and exits when dapr applications exit/stop.

@paulyuk paulyuk added the kind/proposal A new proposal to be considered label Oct 11, 2023
@paulyuk paulyuk added this to the v1.13 milestone Oct 11, 2023
@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Nov 10, 2023
@dapr-bot
Copy link
Collaborator

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@JoshVanL JoshVanL added the P1 label Nov 27, 2023
@pravinpushkar pravinpushkar reopened this Nov 28, 2023
@pravinpushkar
Copy link
Contributor

This got closed as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli area/test/e2e kind/feature New feature or request kind/proposal A new proposal to be considered P1 triaged/resolved The issue has been triaged
Projects
None yet
Development

No branches or pull requests

6 participants