Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a file name should scroll to its diff #88

Open
danvk opened this issue Mar 6, 2015 · 0 comments
Open

Clicking a file name should scroll to its diff #88

danvk opened this issue Mar 6, 2015 · 0 comments
Labels
Milestone

Comments

@danvk
Copy link
Owner

danvk commented Mar 6, 2015

When you have a really long, expanded file list (tall enough that it covers the entire screen), it's a bit surprising that clicking a file name results in no visible changes on the page. The diff does change, but it's off-screen. It would make more sense if clicking the file name scrolled you down to the diff.

This is tricky to get right—scrolling down to the diff might be surprising behavior if there are just a few files and the diff itself is on-screen.

@danvk danvk added the bug label Mar 23, 2015
@danvk danvk added this to the 1.0 milestone Mar 23, 2015
@danvk danvk modified the milestones: 1.0, 1.2.0, 1.3.0 Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant