Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate diff UI lazily for large files #182

Open
danvk opened this issue Jun 5, 2024 · 0 comments
Open

Generate diff UI lazily for large files #182

danvk opened this issue Jun 5, 2024 · 0 comments
Milestone

Comments

@danvk
Copy link
Owner

danvk commented Jun 5, 2024

I believe that generating diffs is quite fast, but generating the UI for them may not be. For example, run:

git webdiff 52aa15f^..52aa15f

from https://github.com/danvk/codediff.js and click through to package-lock.json. There's a noticeable pause while it loads the UI. The diff is long and 99+% of it is offscreen. The lower parts could be generated lazily.

This probably isn't even worth trying without React-ifying codediff.js first.

@danvk danvk modified the milestones: 1.2.0, 1.3.0 Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant