Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-deps started to fail in organize: "The number of frame indices in 'starting_frame' ..." #1442

Closed
yarikoptic opened this issue May 13, 2024 · 2 comments
Labels
tests Add or improve existing tests

Comments

@yarikoptic
Copy link
Member

started around May 8th

DEBUG    dandi:base.py:134 Caught exception (root/acquisition/MouseWhiskers1 GroupBuilder {'attributes': {'comments': 'no comments', 'description': 'no description', 'namespace': 'core', 'neurodata_type': 'ImageSeries', 'object_id': 'c231e662-40a4-4db6-be86-c81dbf112c91'}, 'groups': {}, 'datasets': {'data': root/acquisition/MouseWhiskers1/data DatasetBuilder {'attributes': {'conversion': 1.0, 'offset': 0.0, 'resolution': -1.0, 'unit': 'unknown'}, 'data': <Closed HDF5 dataset>}, 'external_file': root/acquisition/MouseWhiskers1/external_file DatasetBuilder {'attributes': {'starting_frame': array([0, 2])}, 'data': <StrDataset for Closed HDF5 dataset>}, 'format': root/acquisition/MouseWhiskers1/format DatasetBuilder {'attributes': {}, 'data': 'external'}, 'starting_time': root/acquisition/MouseWhiskers1/starting_time DatasetBuilder {'attributes': {'rate': 150.0, 'unit': 'seconds'}, 'data': 0.0}}, 'links': {}}, "Could not construct ImageSeries object due to: ImageSeries 'MouseWhiskers1': The number of frame indices in 'starting_frame' should have the same length as 'external_file'.")
______________________ test_video_organize_common[copy-0] ______________________
dandi/tests/test_organize.py:361: in test_video_organize_common
    assert r.exit_code == rc
E   assert 1 == 0
E    +  where 1 = <Result SystemExit(1)>.exit_code

which is a bit odd since in https://github.com/dandi/dandi-cli/blob/HEAD/dandi/tests/fixtures.py#L736 which is I believe what generates the test case we have

        image_series = ImageSeries(
            name=f"MouseWhiskers{i}",
            format="external",
            external_file=[str(vid_1), str(vid_2)],
            starting_frame=[0, 2],
            starting_time=0.0,
            rate=150.0,
        )

so it does correspond... any recent changes to hdmf/pynwb which we might want to implicate/check here @rly @bendichter ?

@yarikoptic yarikoptic added the tests Add or improve existing tests label May 13, 2024
@rly
Copy link
Contributor

rly commented May 13, 2024

There was a recent change in the dev branch of HDMF that had an unexpected side effect on validation. That change was reverted this morning. It is being documented here. Could you please re-run the test and see if it still appears?

@yarikoptic
Copy link
Member Author

#1443 is indeed all green today so must have indeed been addressed. Thank you @rly !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

No branches or pull requests

2 participants