-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default search seems to not index all dandisets? #1992
Comments
Thank you, Yarik |
Wow, @yarikoptic, you found a good one! First, the workaround: if you perform either of those searches again (by Dandiset ID, or by author's last name), then click on the settings gear to the left of the search bar and turn on "Empty Dandisets", can you confirm that the appropriate search results now show up? Second, the explanation: Dandiset 121 is somewhat odd in that it has published versions (which, by necessity, are not empty), but also a draft version whose assets have all been deleted. The logic for checking for empty Dandisets has a bug in it: it looks only at the oldest version of a Dandiset, and checks that for assets. The oldest version in every Dandiset is the draft version (the draft version is created as soon as the Dandiset is created, and all published versions are necessarily created later). So, in the case of 000121, even though it has published versions (and therefore is not empty), the logic notices that the draft version is empty, and reports the whole Dandiset as being so. Finally, a bigger picture note: even though fixing the bug described above would correctly show Dandiset 121 when searching for My plan here is as follows:
|
(thanks @jjnesbitt for your help in diagnosing this) |
yikes, that is a fun one -- I am not sure how I was that lucky! Thanks for troubleshooting to its surrender! I am confirming that selecting "Empty Datasets" shows it right away. I think there could be yet another solution for search:
So, to suggest to remove filters, and potentially state how many hits then there would be, like in this case could have been
|
In user interface design, these are known as "empty states" (here's a nice website that catalogs a bunch in the wild: https://emptystat.es/). I've opened #2033 to track this. |
We have https://dandiarchive.org/dandiset/000121 which already was released but searching
The text was updated successfully, but these errors were encountered: