Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less aggressive comment highlighting #19

Open
MandL27 opened this issue Sep 23, 2020 · 4 comments
Open

Less aggressive comment highlighting #19

MandL27 opened this issue Sep 23, 2020 · 4 comments

Comments

@MandL27
Copy link

MandL27 commented Sep 23, 2020

Currently, the extension marks @ or ; to end of line as a comment, which can be problematic when an assembler only uses one for comments and uses the other as part of labels. Adding a workspace-level configuration option to change comment character(s) for highlighting would resolve this.

@dan-c-underwood
Copy link
Owner

Hey - I'll try and take a look at this over the next week or so. I'll need to work out how to do it, but I'll try to figure it out 🙂

@dan-c-underwood
Copy link
Owner

Sorry for the delay in coming back on this, unfortunately there appears to be no simple way of adding this as a configuration option currently. Comments and syntax fall under declarative language features rather than programmatic. So VSCode doesn't provide an option, as of yet, to easily modify them on the fly.

I'll leave this issue open though, and will add this feature if VSCode provides a hook that can be easily used in the future.

@etylermoss
Copy link

etylermoss commented Dec 28, 2020

Encountering the same issue, GAS uses ; the same as C, as a linebreak, so you can have multiple statements on a single line, which here is marks the entire line as a comment.

Edit: Is there any relevant issues open on VSCode you're aware of talking about this limitation?

@dan-c-underwood
Copy link
Owner

Nope - but I've just opened one and referenced this issue 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants