When Winston logger is fixed, remove hacky workaround that detects file stream flush / buffer write completion

[danielweck]

master branch:

ace/packages/ace-logger/src/index.js

Lines 40 to 72 in 5d4cc86

	/* eslint-disable no-underscore-dangle */
	// Properly wait that loggers write to file before exitting
	// See https://github.com/winstonjs/winston/issues/228
	winston.logAndExit = function logAndExit(level, msg, codeOrCallback) {
	const self = this;
	this.log(level, msg, () => {
	let numFlushes = 0;
	let numFlushed = 0;
	Object.keys(self.default.transports).forEach((k) => {
	if (self.default.transports[k]._stream) {
	numFlushes += 1;
	self.default.transports[k]._stream.once('finish', () => {
	numFlushed += 1;
	if (numFlushes === numFlushed) {
	if (typeof codeOrCallback === 'function') {
	codeOrCallback();
	} else {
	process.exit(codeOrCallback);
	}
	}
	});
	self.default.transports[k]._stream.end();
	}
	});
	if (numFlushes === 0) {
	if (typeof codeOrCallback === 'function') {
	codeOrCallback();
	} else {
	process.exit(codeOrCallback);
	}
	}
	});
	};

Ace-GUI branch (updated Winston NPM dependency, still the same problem):

ace/packages/ace-logger/src/index.js

Lines 81 to 96 in 449df93

	// Properly wait that loggers write to file before exitting
	// See https://github.com/winstonjs/winston/issues/228
	winston.logAndWaitFinish = async (level, msg) => {
	return new Promise(async (resolve, reject) => {
	winston.log(level, msg);
	for (const transport of transports) {
	try {
	await closeTransportAndWaitForFinish(transport);
	} catch (err) {
	console.log(err);
	}
	}
	resolve();
	});
	};

ace/packages/ace-logger/src/index.js

Lines 11 to 38 in 449df93

	const closeTransportAndWaitForFinish = async (transport) => {
	if (!transport.close) {
	return Promise.resolve();
	}
	return new Promise((resolve, reject) => {
	transport._doneFinish = false;
	function done() {
	if (transport._doneFinish) {
	return;
	}
	transport._doneFinish = true;
	resolve();
	}
	setTimeout(() => {
	done();
	}, 5000);
	const finished = () => {
	done();
	};
	if (transport._stream) {
	transport._stream.once('finish', finished);
	transport._stream.end();
	} else {
	transport.once('finish', finished);
	transport.close();
	}
	});
	}

[danielweck]

Some context:

My report on the Winston issue tracker:
winstonjs/winston#228 (comment)

Somebody recently proposed a fix (submitted a PR):
winstonjs/winston-transport#50

My related comment about the current workaround:
winstonjs/winston-transport#49 (comment)

[danielweck]

Related Ace issue about concurrent access to log files:
#68 (comment)