BUG | sendSettings for screenVideo are ignored in prebuilt increateFrame() calls

[mklepaczewski]

Expected behavior

createFrame() should set screenVideo settings.

Describe the bug (unexpected behavior)

Passing screenVideo encodings during DailyIframe.createFrame() call doesn't set the settings. Instead, following encoding is used:

{ encodings: { low: {dtx: true, maxBitrate: 2000000, scaleResolutionDownBy: 1, maxFramerate: 30} } }

Steps to reproduce

Use following snippet:

callFrame = DailyIframe.createFrame({
            sendSettings: {
                screenVideo: {
                    maxQuality: "low",
                    encodings: {
                        low:    { scaleResolutionDownBy: 10, maxFramerate: 2,  },
                    }
                }
            },
            iframeStyle: {
                position: "fixed",
                border: 0,
                top: 0,
                left: 0,
                width: "100%",
                height: "100%",
            }
        });

        callFrame.on(
            'send-settings-updated',
            function (event) {
                console.log("send-settings-updated", event);
            }
        );

        await callFrame.join({
            url: ROOM_URL,
            token: TOKEN
        });

Open dev console, notice that sendSettings are mostly ignored (see the screenshot)

Screenshots

System information

I'm using Daily 0.58.0, but I also tested it on versions I 100% know used to work, and the bug is there, too.

• Device: PC
• OS, version: Windows, 10
• Browser, version: Chrome Version 121.0.6167.185 (Official Build) (64-bit)

[mattieruth]

Thanks for the report! I'm looking into this.