Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): added RegisterActivityLoaderArgs interface #518

Closed
wants to merge 4 commits into from
Closed

feat(config): added RegisterActivityLoaderArgs interface #518

wants to merge 4 commits into from
+43 −3

Conversation

iamchanii
Copy link
Contributor

@iamchanii iamchanii commented Sep 23, 2024 •
edited
Loading

Backgrounds

As an user, I want to do something in activity loader function with a client likes Relay or TanStack Query and avoid import it directly.

Description

Added RegisterActivityLoadersArgs interface to extends ActivityLoaderArgs.

Changes

  • Added RegisterActivityLoaderArgs interface.
  • Update ActivityLoaderArgs interface to be extend RegisterActivityLoaderArgs interface.
    • And change type declaration keyword to interface from type to be uses extends keyword.

To-Do

  • Pass extends loader args in overrideInitialEvents/onBeforePush/onBeforeReplace cycle. (loaderPlugin)
  • Need changes in preloadPlugin?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 818ec8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@stackflow/config Minor
@stackflow/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Sep 23, 2024 3:18am

@iamchanii iamchanii closed this Sep 23, 2024
@iamchanii
Copy link
Contributor Author

Will be resolved in #509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamchanii