Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Allow to hide search icon for unauthenticated users #2

Open
dantefromhell opened this issue May 16, 2024 · 1 comment
Open

FR: Allow to hide search icon for unauthenticated users #2

dantefromhell opened this issue May 16, 2024 · 1 comment

Comments

@dantefromhell
Copy link

First great thanks for this module!

Would it be possible to allow configure the Search icon too? Or alternatively hide the Search icon for unauthenticated users.

Scenario: If default visibility in Space settings is set to private, clicking the 'Search' icon as unauthenticated user loads the login dialog. For setups in which only selected information is meant to be publicly available, it would be great to be able to hide the search button.

@marc-farre
Copy link
Member

@dantefromhell Thanks for the suggestion. I agree it could be interesting to be able to hide it in some situations.

But on HumHub 1.16, the search button now opens a modal dialog, even if the default visibility in Space settings is set to private. E.g. https://community.humhub.com/

So the use cases would be quite limited. And I personally don't need it.

2 solutions if you want it to be available in this module:

  • you contribute but creating the code yourself (by creating a pull request)
  • you make a donation and I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants