Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard doesn't work in built-in text editor with Gboard keyboard #544

Open
2 tasks done
s-h-a-d-o-w opened this issue Aug 1, 2024 · 4 comments
Open
2 tasks done
Labels
type:feature-request New feature or request

Comments

@s-h-a-d-o-w
Copy link

Please agree to the following

Summary

Clipboard doesn't work in built-in text editor

System Setup

- Android: 14
- Cryptomator: 1.10.2

Cloud Type

Google Drive

Steps to Reproduce

  1. Create a text file and edit it.
  2. Select and copy some text.

Expected Behavior

The copied text should be in the clipboard.

Actual Behavior

Whatever was previously in the clipboard is still there. I.e. copying/cutting text simply doesn't do anything. (Well... cutting deletes the text without an ability to get it back.)

Reproducibility

Always

Relevant Log Output

No response

Anything else?

No response

@s-h-a-d-o-w s-h-a-d-o-w added the type:bug Something isn't working label Aug 1, 2024
@SailReal
Copy link
Member

SailReal commented Aug 2, 2024

Is there a difference to what I'm doing here?

screen-20240802-145807.mp4

@s-h-a-d-o-w
Copy link
Author

So yeah, it's half my bad. I tend to use the Gboard clipboard because it's faster than holding down and pasting and shows a preview. This is the first app I've used where it seems like the system clipboard and the Gboard clipboard diverge.

Hence "half my bad" - I think it's understandable that I didn't realize what's going on but on the other hand, the cryptomator app clearly supports the clipboard to some extent. Personally, I'm fine now that I know but it of course would be nice if you could support the Gboard clipboard (might also be other keyboards) if it can be done easily.

Screen_Recording_20240802_151956_Cryptomator.mp4

@SailReal
Copy link
Member

SailReal commented Aug 2, 2024

In every input field in Cryptomator, we are setting a flagNoPersonalizedLearning which prevents the keyboard from training with this data, see e.g.

android:imeOptions="flagNoPersonalizedLearning"

and also flagNoPersonalizedLearning in https://developer.android.com/reference/android/widget/TextView#attr_android:imeOptions for further information.

It looks like Gboard disables the clipboard if this flag is set.
If I remove it:

screen-20240802-154003.mp4

The only option would be to introduce an option in Cryptomator settings to disable flagNoPersonalizedLearning but I would not recommend this to users because Cryptomator is an privacy/security app and instead would recommend another keyboard.

...should we keep this open and turn it into a feature request to make the flagNoPersonalisedLearning flag configurable, or should we close it and keep it for documentation?

@s-h-a-d-o-w
Copy link
Author

s-h-a-d-o-w commented Aug 2, 2024

Personally, I see the privacy concerns regarding this as partly beyond cryptomator's responsibility. What I mean by this - cryptomator is for encrypting files on cloud drives and that's mostly it. However, I agree that this default behavior shouldn't be changed (for the reasons that you mentioned). But I think offering it as an option in the settings would be good.

(In case other people stumble across this, I would like to point out that other than using a privacy-respecting keyboard (something that I agree with - I only use Gboard for reasons I won't go into right here), one can also work around this by using "Open with..." on a file and using an app like e.g. QuickEdit+ for text files.)

@SailReal SailReal changed the title Clipboard doesn't work in built-in text editor Clipboard doesn't work in built-in text editor with Gboard keyboard Aug 2, 2024
@SailReal SailReal added type:feature-request New feature or request and removed type:bug Something isn't working labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants