Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Custom Viewer Roles do not update when usernames are changed on Twitch #2203

Closed
1 task done
huds601 opened this issue Jul 15, 2023 · 4 comments
Closed
1 task done
Assignees
Labels
Bug A defect in the app

Comments

@huds601
Copy link

huds601 commented Jul 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I use Viewer Roles to keep track of a one-time redemption for sticker giveaways. When the user redeems the channel point reward, it adds the role to them to that, if they try to redeem again, it will reject the redemption and refund the points.

I noticed that one of my viewers was able to redeem a second time, and they had recently changed their Twitch username.

Their old name was cowboyknuckles, their new name is CBK_x.

However, in the Custom Role, they are still showing as cowboyknuckles, but only appear as CBK_x in my viewers database. While one of the 2 roles I use is applied the one they redeemed before changing their name is no longer applied to their account.

Profile
Custom Role

Expected Behavior

Custom roles should follow users post-name change

Steps To Reproduce

  1. Add a Twitch user to a custom role
  2. Change the username of the Twitch user

Version

5.57.0

What operating system are you using Firebot on?

Windows 10

Relevant log output

No response

Contact Details (Optional)

Discord: huds601

@huds601 huds601 added the Bug A defect in the app label Jul 15, 2023
@CKY-
Copy link
Collaborator

CKY- commented Jul 15, 2023

part of #2198

@JoeruCodes
Copy link
Contributor

one possible fix for this could be the use of userID tracking rather than username tracking
which means that instead of assigning the roles to the usernames (which can be changed) we can assign the same to the userID (which cannot be changed even after changing the username)

@itsjesski itsjesski added the v6 Enhancement that will likely not be considered until v6 label Jan 5, 2024
@itsjesski
Copy link
Collaborator

Tagging as v6 based on the info in #2198

@zunderscore zunderscore self-assigned this Feb 20, 2024
@zunderscore zunderscore removed the v6 Enhancement that will likely not be considered until v6 label Feb 20, 2024
@github-actions github-actions bot added Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release labels Feb 23, 2024
@zunderscore
Copy link
Collaborator

Released in v5.62.0

@github-actions github-actions bot removed Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release labels Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app
Projects
Status: Closed
Development

No branches or pull requests

5 participants