Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically setup basic otel/prometheus metrics #20

Open
negz opened this issue Sep 14, 2023 · 3 comments
Open

Automatically setup basic otel/prometheus metrics #20

negz opened this issue Sep 14, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@negz
Copy link
Member

negz commented Sep 14, 2023

What problem are you facing?

It would be neat if we could automatically wrap Functions with some basic observability (e.g. metrics, tracing). Ideally we'll need a format that could be consistent across Functions built in other in-demand languages - e.g. Python.

How could Crossplane help solve your problem?

There's a bunch of stuff in https://github.com/grpc-ecosystem - perhaps this SDK should start a gRPC server that uses one of the interceptors there to add at least basic Prometheus-style metrics?

@negz negz added the enhancement New feature or request label Sep 14, 2023
@phisco
Copy link
Collaborator

phisco commented Sep 18, 2023

for sure I'd go with prometheus metrics, https://github.com/grpc-ecosystem/go-grpc-middleware/tree/main/providers/prometheus feels like the suggested way to do that.

@negz
Copy link
Member Author

negz commented Sep 18, 2023

@phisco I think there's an otel equivalent that gives traces and metrics. Could be worth considering. To be clear, the metrics are exposed in Prom-style /metrics, it's just a different library doing it. That said, last time I checked the otel metrics packages were pretty unstable API wise.

@phisco
Copy link
Collaborator

phisco commented Sep 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants