Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing bigqueryConfig for pubsub subscriptions #469

Open
POD666 opened this issue Oct 4, 2022 · 4 comments · May be fixed by #476
Open

Missing bigqueryConfig for pubsub subscriptions #469

POD666 opened this issue Oct 4, 2022 · 4 comments · May be fixed by #476
Labels
enhancement New feature or request

Comments

@POD666
Copy link

POD666 commented Oct 4, 2022

What problem are you facing?

I want to provision a subscription with bigquery type but it seems to be missing.

How could Crossplane help solve your problem?

Add missing configs. I have manually configured a subscription this way:

$ gcloud pubsub subscriptions describe my-bigquery-subscription
ackDeadlineSeconds: 10
bigqueryConfig:
  state: ACTIVE
  table: ...
  useTopicSchema: true
  writeMetadata: true
enableMessageOrdering: true
expirationPolicy:
  ttl: 604800s
messageRetentionDuration: 86400s
name: ...
pushConfig: {}
retainAckedMessages: true
retryPolicy:
  maximumBackoff: 600s
  minimumBackoff: 10s
state: ACTIVE
topic: ...
@POD666 POD666 added the enhancement New feature or request label Oct 4, 2022
@POD666
Copy link
Author

POD666 commented Oct 5, 2022 •
edited
Loading

I would prepare a PR and it's actually partially ready here but I have low exp with go and I'm stuck at updating google.golang.org/api from v0.52.0 to v0.97.0 (needed to include bigquery API struct).

I stuck at this:

$ make -j4                                                                                                                git:(bigquery-subscription-type) ✗  
18:07:04 [ .. ] verify go modules dependencies have expected content
all modules verified
18:07:07 [ OK ] go modules dependencies verified
18:07:08 [ .. ] go build linux_amd64
github.com/crossplane-contrib/provider-gcp/pkg/clients/cluster
github.com/crossplane-contrib/provider-gcp/pkg/clients/subscription
# github.com/crossplane-contrib/provider-gcp/pkg/clients/cluster
pkg/clients/cluster/cluster.go:1008:5: unknown field 'DesiredAutopilot' in struct literal of type container.ClusterUpdate
github.com/crossplane-contrib/provider-gcp/pkg/controller/pubsub
18:07:08 [FAIL]
make[3]: *** [go.build] Error 1
make[2]: *** [do.build.platform.linux_amd64] Error 2
make[1]: *** [build.all] Error 2
make: *** [build] Error 2

And indeed, DesiredAutopilot is gone from ClusterUpdate in the newer google.golang.org/api.

Any advice to proceed?

@Feggah
Copy link
Collaborator

Feggah commented Oct 5, 2022

Hey @POD666, unfortunately, we already have two WIP PRs that are solving this issue.

I want to merge any of them ASAP to avoid this duplication of efforts and solve this problem.

@POD666
Copy link
Author

POD666 commented Oct 6, 2022

Oh, great. So the moment one of them is merged, I could rebase and proceed with bigqueryConfig.

@Feggah
Copy link
Collaborator

Feggah commented Oct 7, 2022

Oh, great. So the moment one of them is merged, I could rebase and proceed with bigqueryConfig.

The #470 has been merged today. I think you can rebase and proceed now 🙂

@POD666 POD666 linked a pull request Oct 11, 2022 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bigquery subscription type support POD666/provider-gcp
2 participants
@POD666 @Feggah