Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite showing ready status when one of the resources cannot render #12

Open
stevendborrelli opened this issue Sep 30, 2023 · 1 comment

Comments

@stevendborrelli
Copy link
Collaborator

In porting over platform-ref-aws to P&T, I noticed that the Helm releases were unhealthy, but the overall composite showed healthy:

kubectl get composite 
xeks.aws.platformref.upbound.io/borrelli-function-test-9pq6z-62qdh   True     True    xeks.aws.platformref.upbound.io   70m

This helm ProviderConfig and KubernetesClusterAuth not generating was due to a patch that needed a field Type added to it:

        transforms:
                - type: string
                  string:
                    type: Format # missing
                    fmt: "%s-ekscluster"
  Warning  ComposeResources         4m48s (x43 over 70m)  defined/compositeresourcedefinition.apiextensions.crossplane.io  Pipeline step "patch-and-transform": cannot render FromComposite patches for composed resource "kubernetesClusterAuth": cannot apply the "FromCompositeFieldPath" patch at index 1: transform at index 0 returned error: string transform could not resolve: type  is not supported for string transform type

I believe this composite should have shown that it could not render a resource:

Status:
  Conditions:
    Last Transition Time:  2023-09-30T07:11:06Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2023-09-30T08:19:07Z
    Reason:                Available
    Status:                True
    Type:                  Ready
@MisterMX
Copy link
Contributor

I believe this should be fixed with #81?

Anyways, I created a PR for a similar problem that makes a composite show to be ready although some resources are skipped due to missing required patches: #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants