Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit tests to modularize the visualizer #8

Open
adam2392 opened this issue Jan 11, 2021 · 0 comments
Open

Adding unit tests to modularize the visualizer #8

adam2392 opened this issue Jan 11, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@adam2392
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now, the entire visualizer sits inside src/, which makes it difficult to unit test and parse.

Describe the solution you'd like
With unit tests added, we can add the following to the CI config:

- run:
          name: Jest tests
          command: yarn coverage --maxWorkers=2
      - run:
          name: Upload to codecov
          command: yarn codecov

Additional context
See https://github.com/bids-standard/bids-validator for an example of how they do some unit testing in javascript.

@adam2392 adam2392 added the enhancement New feature or request label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant