You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder if it would make sense to rename the column after the fee is considered to make it more explicit that we are already accounting for surplus (I remember a Uniswap data analysis where they accounted for the LP twice because they didn't realize it was already accounted for in some earlier step of the process).
Something like atoms_sold - coalesce(surplus_fee, 0) as atoms_sold_after_fee,
The problem here is that the query will need to be updated to and we would like to "own" the query. If you are planning to implement this change, then I would propose that you fork our current query, make the necessary changes then we will fork yours and use that.
Something like
atoms_sold - coalesce(surplus_fee, 0) as atoms_sold_after_fee,
Originally posted by @fleupold in #160 (comment)
The text was updated successfully, but these errors were encountered: