Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename atoms_sold Column in period_slippage #161

Open
bh2smith opened this issue Dec 19, 2022 · 2 comments
Open

rename atoms_sold Column in period_slippage #161

bh2smith opened this issue Dec 19, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@bh2smith
Copy link
Contributor

    I wonder if it would make sense to rename the column after the fee is considered to make it more explicit that we are already accounting for surplus (I remember a Uniswap data analysis where they accounted for the LP twice because they didn't realize it was already accounted for in some earlier step of the process).

Something like atoms_sold - coalesce(surplus_fee, 0) as atoms_sold_after_fee,

Originally posted by @fleupold in #160 (comment)

@rblcoder
Copy link

What should the column be renamed to?

@bh2smith
Copy link
Contributor Author

bh2smith commented Jan 10, 2023

Well the current working suggestion is:

atoms_sold_after_few

The problem here is that the query will need to be updated to and we would like to "own" the query. If you are planning to implement this change, then I would propose that you fork our current query, make the necessary changes then we will fork yours and use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants