fix(widget): widget tokens flickering #4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
reviewed
Sep 13, 2024
|
|
||
| useEffect(() => { | ||
| if (!state?.tradeType) return | ||
| if (isFirstLoad.current && !!state) { |
There was a problem hiding this comment.
I see this is a key change to break the loop.
But what the point of creating tradeStateFromUrlAtom? Probably you did it to cache the tradeStateFromUrl value, correct?
There was a problem hiding this comment.
Correct! I thought at first that could be related, since the hook is included in multiple places causing it to be constantly re-evaluated. Decided to add since it was already done 🤷
shoom3301
approved these changes
Sep 13, 2024
elena-zh
approved these changes
Sep 13, 2024
alfetopito
force-pushed
the
fix/4879-widget-tokens-flickering
branch
from
2f8815d
to
bf80037
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4879
Due to a race condition between parent widget props and inner app state, the tokens endup flickering non-stop.
This change makes sure on the first load, the app refrain from sending the state update event.
The side effect is that the state previously set in the widget will be always cleared in favor of the param coming from the parent widget - but only if they listen to the widget events.
To Test