Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: PollParams to accept orderbook instance #181

Open
2 tasks
mfw78 opened this issue Oct 19, 2023 · 0 comments
Open
2 tasks

chore: PollParams to accept orderbook instance #181

mfw78 opened this issue Oct 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mfw78
Copy link
Contributor

mfw78 commented Oct 19, 2023 •
edited
Loading

Background

When using PollParams in downstream (watch-tower), it's frustrating to have to pass the orderbook config when the watch-tower already has an instantiated orderbook instance.

Details

Adjust the PollParams so that it accepts an instance of the orderbook api sdk.

Acceptance criteria

  • Downstream consumers don't pass orderbook config to anything except the orderbook's new constructor.
  • Orderbook instances are passed into the SDK's polling methods.

Context

          i see what you mean. Yes, makes sense to pass an instance of the Orderbook API SDK

Originally posted by @anxolin in cowprotocol/watch-tower#112 (comment)
@mfw78 mfw78 changed the title i see what you mean. Yes, makes sense to pass an instance of the Orderbook API SDK chore: PollParams to accept orderbook instance Oct 19, 2023
@mfw78 mfw78 added the enhancement New feature or request label Oct 19, 2023
@mfw78 mfw78 mentioned this issue Oct 19, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfw78