Added example on CRI parsing longlogs #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-coralogix
requested review from
avivgold098,
ShauliSolomovich,
povilasv,
oded-dd,
matej-g and
nicolastakashi
as code owners
nicolastakashi
added
the
skip changelog
|
@juan-coralogix can you run |
matej-g
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Looks good, some stylistic suggestions + @nicolastakashi already mentioned we should fix the failing CI
Co-authored-by: Matej Gera <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
nicolastakashi
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just adds an example to Readme.
On how to fix LongLogs in CRI / containerd with concat.
How Has This Been Tested?
Its a readme, no testing done. But the configuration added to the readme has been tested in a UseCase scenario.
Checklist: