Add in_memory storage option #2356
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
reviewed
Dec 4, 2020
src/headless/core.js
Outdated
| @@ -998,6 +998,9 @@ function initPersistentStorage () { | |||
| } else if (_converse.api.settings.get("persistent_store") === 'IndexedDB') { | |||
| config['description'] = 'indexedDB instance'; | |||
| config['driver'] = [Storage.localForage.INDEXEDDB]; | |||
| } else if (_converse.api.settings.get("persistent_store") === 'in_memory') { | |||
There was a problem hiding this comment.
I prefer none to in_memory for the config setting value.
It's more semantic because strictly speaking, there is no persistent storage in this case.
|
Thanks @XaviFP. The tests are failing and need to be fixed first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary work for conversejs/skeletor#6
Changed git hash to not forget about updating it when it gets merged.
CHANGES.mddocument it in
docs/source/configuration.rstwith
make checkor you can run them in the browser by runningmake serveand then opening
http://localhost:8000/tests.html.