Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCG] Detect bug for edit with the multiple handler (edit/override all) #46

Open
baumannsven opened this issue May 21, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@baumannsven
Copy link
Member

You detect here https://github.com/menatwork/contao-multicolumnwizard-bundle/blob/master/src/EventListener/Contao/ExecutePostActions.php#L92 for editAll.
I think this for DC_Table.

Can you please support the dc-general as well?

Here a example i detect the multiple handler is in the right edit view:

// This detect both modes (edit and override all)
('select' === $inputProvider->getParameter('act'))
               && ('edit' === $inputProvider->getParameter('mode'));

Here is the post value how mcw becomes by the action mcwCreateNewRow.

tl_metamodel____5_[languages]
@discordier
Copy link
Member

Could you file a PR?

@baumannsven
Copy link
Member Author

I have post the link where problem is

@stefanheimes
Copy link
Member

So the problem is the DCG and Contao, both need a handler which 1. detect we have to change something and 2. make a change in the name.

Who can tell me the answer for the first and who can tell me what do to for the second point. The MCW, all the time? I don't think so. Maybe we should make a event for this? I don't want to rewrite all the time this part, because something change. With an event the DCG or other drivers can handle this by her own.

What do you thing @discordier @baumannsven @zonky2

@stefanheimes stefanheimes added enhancement New feature or request question Further information is requested labels May 23, 2019
@stefanheimes stefanheimes self-assigned this May 23, 2019
@stefanheimes stefanheimes added this to the 3.4.x milestone May 23, 2019
@baumannsven
Copy link
Member Author

baumannsven commented May 23, 2019

You do not must create an event for this. The container input name can manipulate in the CreateWidgetEvent . I think mcw is the right place for get the input name in edit override all mode.

MCW is a third party extension. Therefore it should support the DCG completely. And not the DCG a third party extension. The handling of override/edit all has not and will not change since it was implemented. Before the MCW change to a bundle it worked.

@zonky2 zonky2 modified the milestones: 3.4.x, 3.5.x Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants