-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
too many network aliases when recreating the container #521
Comments
Hi there! 👋🏼 As you're new to this repo, we'd like to suggest that you read our code of conduct as well as our contribution guidelines. Thanks a bunch for opening your first issue! 🙏 |
Hi, Would you mind expanding on what the issue is and when it occurs? Thanks, |
The issue IMHO is that a lot of aliases are accumulating over time (one additional alias per recreate). These are just the container IDs of former instances of this Docker container, which most probably do not serve any purpose, so they could be filtered out when recreating the container. |
It seems like code from #1699 removes necessary labels added by docker compose.
After restarting:
Docker compose added service name |
That was an oversight, yeah. I think we can deduce from labels what networks are "actual" aliases. A regex could potentially match a valid real alias name... |
The text was updated successfully, but these errors were encountered: