Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return code from command not returned by krunvm #21

Open
c3d opened this issue Aug 4, 2022 · 1 comment
Open

Return code from command not returned by krunvm #21

c3d opened this issue Aug 4, 2022 · 1 comment

Comments

@c3d
Copy link

c3d commented Aug 4, 2022

I noticed that because of #20:

% krunvm start fedora-rawhide  /bin/ls -- -l /bin/false
-rwxr-xr-x 1 root root 69808 Aug  1 15:36 /bin/false
% krunvm start fedora-rawhide  /bin/false
% echo $?
0

The expected returned value would be 1, since that's what /bin/false returns.

This may make it difficult to use krunvm in scripts. For example, I could not write a host script that does a build and test whether the build succeeded.

@slp
Copy link
Collaborator

slp commented Aug 4, 2022

This is actually a libkrun issue, related to containers/libkrun#10. A interface needs to be designed to transport that information between the host and the guest in a way that doesn't require the intervention of a dedicated agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants