Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SkipOptimisation #243

Open
yebai opened this issue Sep 6, 2024 · 3 comments
Open

Add SkipOptimisation #243

yebai opened this issue Sep 6, 2024 · 3 comments
Labels
enhancement (performance) Would reduce the time it takes to run some bit of the code

Comments

@yebai
Copy link
Contributor

yebai commented Sep 6, 2024 •
edited
Loading

We could optimise functions that we know won't influence gradients. Some examples from ReverseDiff:

Any others?
@yebai yebai added the enhancement (performance) Would reduce the time it takes to run some bit of the code label Sep 6, 2024
@willtebbutt
Copy link
Member

We actually do this quite a bit already. See here. It might make sense for me to split this out into a separate file though, so that it's more clearly labelled, rather than just being under "misc".

@yebai
Copy link
Contributor Author

yebai commented Sep 6, 2024

It might make sense for me to split this out into a separate file though

That's not critical as long as we have explicit comments on the purpose in the file.

@willtebbutt
Copy link
Member

Sounds good. I've just reviewed the comment associated to them, and it's quite outdated. I'll make updating / improving it part of this issue.

@willtebbutt willtebbutt mentioned this issue Sep 6, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement (performance) Would reduce the time it takes to run some bit of the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yebai @willtebbutt