Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move slice functions from vector to *.Partial #200

Open
bjornbm opened this issue Sep 12, 2019 · 2 comments · May be fixed by #201
Open

Move slice functions from vector to *.Partial #200

bjornbm opened this issue Sep 12, 2019 · 2 comments · May be fixed by #201

Comments

@bjornbm
Copy link
Contributor

bjornbm commented Sep 12, 2019 •
edited
Loading

The slice functions from vector are partial, which I assumed means they should be moved to the *.Partial modules? Applies to:

  • RIO.Vector.Unboxed
  • RIO.Vector.Storable
  • RIO.Vector.Boxed
  • RIO.Vector

Perhaps add safe versions returning Maybe (Vector a)?
@snoyberg
Copy link
Collaborator

Good call, this is definitely an oversight. Want to send a PR?

@bjornbm
Copy link
Contributor Author

bjornbm commented Sep 14, 2019

Sure, I hope to find time next week.

@bjornbm bjornbm linked a pull request Sep 22, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move slice to Partial, add sliceMaybe function bjornbm/rio
2 participants
@bjornbm @snoyberg