Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove segment_start_times usage (and friends) #536

Open
adeebshihadeh opened this issue Jun 26, 2024 · 1 comment · May be fixed by #539
Open

Remove segment_start_times usage (and friends) #536

adeebshihadeh opened this issue Jun 26, 2024 · 1 comment · May be fixed by #539

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jun 26, 2024

Need to remove segment_start_times, segment_end_times, and segment_numbers since we'll no longer have this information soon.

They're primarily used for file uploads. We'll replace them with:

  • make the following assumptions
    • route starts at segment 0
    • segments are 60s
    • segments aren't missing in the middle of the route
  • add an "Upload all for route" button that requests uploads for range(0, max_seg_number+1). this is a fallback for cases where the assumptions don't hold true

With those assumptions, the file upload should be mostly unaffected.

if (currentRoute.segment_start_times[i] < adjusted_start_time + loop.duration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Open
Development

Successfully merging a pull request may close this issue.

2 participants
@adeebshihadeh and others